Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not listen on SIGBUS, SIGFPE, SIGSEGV and SIGILL #40

Merged
merged 1 commit into from
Sep 8, 2016

Conversation

addaleax
Copy link
Contributor

@addaleax addaleax commented Sep 5, 2016

Listening for one of these signals from JS will make the process enter an infinite loop when encountering them naturally because the underlying problem is not resolved while the signal handler is being scheduled.

Ref: npm/npm#13782 (real problem caused by this :/)
Ref: nodejs/node#8410 (me wanting to warn about this in the Node.js docs)

Listening for one of these signals from JS will make the process
enter an infinite loop when encountering them naturally
because the underlying problem is not resolved while the signal
handler is being scheduled.

Ref: npm/npm#13782
Ref: nodejs/node#8410
@addaleax
Copy link
Contributor Author

addaleax commented Sep 8, 2016

hmm, /cc @bcoe?

@bcoe
Copy link
Member

bcoe commented Sep 8, 2016

👍 thanks for the patch.

@bcoe bcoe merged commit 5b105fb into tapjs:master Sep 8, 2016
@addaleax addaleax deleted the no-sigsegv branch September 8, 2016 15:38
@addaleax
Copy link
Contributor Author

addaleax commented Sep 8, 2016

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants