Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS setCookie #32

Open
GoogleCodeExporter opened this issue Apr 6, 2015 · 3 comments
Open

iOS setCookie #32

GoogleCodeExporter opened this issue Apr 6, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?

1. Open the Touch Example App
2. Validate for App Store submission
3. Validator responds with - iTunes Store operation failed. The app references 
non-public selectors ... setCookies. See attached image.



What version of the product are you using? On what operating system?

The latest (r124)



Please provide any additional information below.

The following fixes the validation, but evidently will limit functionality if 
it breaks any sort of NSHTTPCookieStorage logic. 

Changing GTMHTTPFetcher.h:396

from:

- (void)setCookies:(NSArray *)newCookies;

to:

- (void)setCookiesNow:(NSArray *)newCookies;

& changing GTMHTTPFetcher.m:983

from:

[cookieStorage_ setCookies:cookies];

to;

[cookieStorage_ setCookiesNow:cookies];

Original issue reported on code.google.com by Steve.W....@gmail.com on 29 Sep 2014 at 12:16

Attachments:

@GoogleCodeExporter
Copy link
Author

If FetchHistory is built in, that will go away because the selector will be 
implemented by the app.  But if you only need OAuth2 without the fetchers 
history, that could be a problem.  We'll take a look, renaming it might ripple 
to other things, we will have to check.

Original comment by thomasvl@google.com on 29 Sep 2014 at 1:54

@GoogleCodeExporter
Copy link
Author

Yes, thats what i was thinking. Let me know what your checks show and if 
renaming it will work, although i'm sure it is named setCookies in order to be 
compatible with an NS class for cookie logic. Id prefer not to lose any cookie 
functionality if possible.

Thanks.

Original comment by Steve.W....@gmail.com on 30 Sep 2014 at 1:32

@GoogleCodeExporter
Copy link
Author

The same problem I faced. We commented the call of setCookies. 

Original comment by manish.n...@gmail.com on 2 Feb 2015 at 12:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant