SQL table: ->find(['TEST_ID' => 1]) lists all rows but only with the data from first row ?

[zilveer]

Hi,
I am using SQL tables with mapper but I have issues with fetching correct data when using SQL tables.

I am using the lastest versions of php-client and php-mapper, the dev repo.

This is how you can re-produce the issue:

tarantoolctl enter myplace
\set language sql
CREATE TABLE users (id INTEGER PRIMARY KEY AUTOINCREMENT, some_id INTEGER, test_id INTEGER)
INSERT INTO user (some_id, test_id) VALUES (78, 1)
INSERT INTO user (some_id, test_id) VALUES (43, 2)
INSERT INTO user (some_id, test_id) VALUES (12, 1)

With using php-mapper I am doing this:
$testing = $mapper->getRepository('USERS')->find(['TEST_ID' => 1]);
the result is:

array (size=3)
  0 => 
    object(Tarantool\Mapper\Entity)[602]
      public 'ID' => int 1
      public 'SOME_ID' => int 78
      public 'TEST_ID' => int 1
  1 => 
    object(Tarantool\Mapper\Entity)[602]
      public 'ID' => int 1
      public 'SOME_ID' => int 78
      public 'TEST_ID' => int 2
  2 => 
    object(Tarantool\Mapper\Entity)[602]
      public 'ID' => int 1
      public 'SOME_ID' => int 78
      public 'TEST_ID' => int 1

Which means that is actually just returns all rows but with the content of the first row in the table when it should return:

array (size=3)
  0 => 
    object(Tarantool\Mapper\Entity)[602]
      public 'ID' => int 1
      public 'SOME_ID' => int 78
      public 'TEST_ID' => int 1
  1 => 
    object(Tarantool\Mapper\Entity)[602]
      public 'ID' => int 3
      public 'SOME_ID' => int 12
      public 'TEST_ID' => int 1

If you have any questions regarding this please let me know.
If you can fix this bug I would be very happy.

regards Zilveer

[zilveer]

I have found where the bug is causing the issue,
In Repository.php file line 213-219 there is a code:

foreach ($data as $tuple) {
    $instance = $this->getInstance($tuple);
    if ($one) {
        return $this->results[$cacheKey] = $instance;
    }
    $result[] = $instance;
}

I replaced it with:

foreach ($data as $tuple) {
    echo 'tuple:';
    var_dump($tuple);
    $instance = $this->getInstance($tuple);
    echo 'instance:';
    var_dump($instance);
    echo '<hr>';
    if ($one) {
        return $this->results[$cacheKey] = $instance;
    }
    $result[] = $instance;
}

and it seems to me that the request to $this->getInstance($tuple); is only returning the first row even though the tuple is shown with correct data (test my code and you will see).

EDIT:
I changed getTupleKey to the following code in Space.php:

public function getTupleKey(array $tuple)
{
    $key = [];
    foreach ($this->getPrimaryIndex()['parts'] as $part) {
        echo 'part';
        var_dump($part);
        if(isset($part[0]))
            $key[] = $tuple[$part[0]];
        if(isset($part['field']))
            $key[] = $tuple[$part['field']];
        
    }
    return count($key) == 1 ? $key[0] : implode(':', $key);
}

and now it shows all rows data correct, but it still shows all rows, so probably the function getInstance in file Repository.php needs to be adapted for SQL tables to only return the correct data.

regards Zilveer

[nekufa]

Hello @zilveer, thanks for you feedback!
I found out why sql-based spaces were not working - index format was changed.
This bug was fixed in the latest version, let me know if something else goes wrong.

[zilveer]

@nekufa Perfect, i Will test it again.

Regards

[zilveer]

Perfect it works good now!