Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new names to old formats on alter #3011

Closed
Gerold103 opened this issue Dec 20, 2017 · 1 comment
Closed

Add new names to old formats on alter #3011

Gerold103 opened this issue Dec 20, 2017 · 1 comment
Assignees
@Gerold103
Labels
feature A new functionality
Milestone
1.9.0

Comments

@Gerold103
Copy link
Collaborator

On space format alteration change field names for all formats, not for only new one.
@Gerold103 Gerold103 added the feature A new functionality label Dec 20, 2017
@Gerold103 Gerold103 self-assigned this Dec 20, 2017
@Gerold103
Copy link
Collaborator Author

Proposal:

Space creation initializes empty names storage.
Space alter checks, if any field has changed its name. If it did, then create ModifySpaceFormat operation. ModifySpaceFormat refs names hash in old names storage, creates a new names hash in the same names storage.
ModifySpaceFormat::rollback returns old names hash to the names storage.
ModifySpaceFormat's destructor deletes saved names hash.
Tuple format refs names storage in tuple_format_new.

Gerold103 added a commit that referenced this issue Dec 28, 2017
@Gerold103
tuple: move tuple field names hash to a separate shared struct
9557c53 
Struct tuple_dictionary stores hash of field names, defined in
a space format. The structure is refable and are going to be used
to share new field names with old space formats.

Part of #3011
Gerold103 added a commit that referenced this issue Dec 28, 2017
@Gerold103
alter: introduce ModifySpaceFormat alter operation
a6f6c5c 
ModifySpaceFormat operation sets new names into old tuple formats.

Closes #3011
@kostja kostja added this to the 1.7.7 milestone Jan 9, 2018
@kostja kostja modified the milestones: 1.7.7, 1.8.7 Jan 22, 2018
kostja pushed a commit that referenced this issue Jan 23, 2018
@Gerold103 @kostja
tuple: move tuple field names hash to a separate shared struct
c94034d 
Struct tuple_dictionary stores hash of field names, defined in
a space format. The structure is refable and are going to be used
to share new field names with old space formats.

Part of #3011
kostja pushed a commit that referenced this issue Jan 23, 2018
@Gerold103 @kostja
alter: introduce ModifySpaceFormat alter operation
9f6113a 
ModifySpaceFormat operation sets new names into old tuple formats.

Closes #3011
@kostja kostja modified the milestones: 1.8.7, 1.7.7 Jan 23, 2018
@kostja kostja closed this as completed Jan 23, 2018
@kyukhin kyukhin mentioned this issue Mar 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gerold103 Gerold103

Labels
feature A new functionality
Projects
None yet
Milestone
1.9.0
Development

No branches or pull requests
2 participants
@kostja @Gerold103