Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LuaJIT: overflow of FFI finalizers table unconditionally leads to panic. #3060

Closed
kostja opened this issue Jan 19, 2018 · 1 comment · Fixed by #9372
Closed

LuaJIT: overflow of FFI finalizers table unconditionally leads to panic. #3060

kostja opened this issue Jan 19, 2018 · 1 comment · Fixed by #9372
Assignees
@mkokryashkin
Labels
luajit
Milestone
wishlist

Comments

@kostja
Copy link
Contributor

kostja commented Jan 19, 2018

When number of FFI objects in the interpreter grows beyond a certain limit, LuaJIT simply ends with panic. This is unacceptable for 24x7 apps.
Test case:
https://github.com/tarantool/tarantool/blob/1.7/test/long_run-py/finalizers.test.py
@kostja kostja added the luajit label Jan 19, 2018
@kostja kostja added this to the wishlist milestone Jan 19, 2018
@kostja kostja added luajit and removed luajit labels Feb 7, 2018
@Totktonada
Copy link
Member

See also #3751 and 022a3c5.

@igormunkin igormunkin self-assigned this Jan 24, 2020
@igormunkin igormunkin removed their assignment Jul 25, 2021
@igormunkin igormunkin removed the teamL label Sep 15, 2022
mkokryashkin added a commit to mkokryashkin/tarantool that referenced this issue Nov 15, 2023
@mkokryashkin
test: remove finalizers table overflow test
4668344 
This test is no longer needed in the Tarantool test suite
since it was added to LuaJIT's test suite along with the fix
for the issue mentioned in tarantool#3060 in scope of tarantool#8825 in commit
7b98314e0dacc7313c061aceeb0a32afd4e8cbce ('Fix frame for more
types of on-trace error messages.').

Closes tarantool#3060
Related to tarantool#8825

NO_DOC=Cleanup
NO_TEST=Already included in LuaJIT bump
NO_CHANGELOG=Already included in LuaJIT bump
@mkokryashkin mkokryashkin mentioned this issue Nov 15, 2023
Merged
mkokryashkin added a commit to mkokryashkin/tarantool that referenced this issue Nov 16, 2023
@mkokryashkin
test: remove finalizers table overflow test
7db209d 
This test is no longer needed in the Tarantool test suite
since it was added to LuaJIT's test suite along with the fix
for the issue mentioned in tarantool#3060 in scope of tarantool#8825 in commit
tarantool/luajit@7b98314.

Closes tarantool#3060
Related to tarantool#8825

NO_DOC=Cleanup
NO_TEST=Already included in LuaJIT bump
NO_CHANGELOG=Already included in LuaJIT bump
igormunkin pushed a commit that referenced this issue Nov 16, 2023
@mkokryashkin @igormunkin
test: remove finalizers table overflow test
e99f6cb 
This test is no longer needed in the Tarantool test suite
since it was added to LuaJIT's test suite along with the fix
for the issue mentioned in #3060 in scope of #8825 in commit
tarantool/luajit@7b98314.

Closes #3060
Related to #8825

NO_DOC=Cleanup
NO_TEST=Already included in LuaJIT bump
NO_CHANGELOG=Already included in LuaJIT bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkokryashkin mkokryashkin

Labels
luajit
Projects
None yet
Milestone
wishlist
Development

Successfully merging a pull request may close this issue.

test: remove finalizers table overflow test mkokryashkin/tarantool
4 participants
@Totktonada @kostja @igormunkin @mkokryashkin