test: remove finalizers table overflow test #9372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buristan
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Hi, Maxim!
Thanks for the patch!
LGTM, but I suggest mentioning the commit from another repo like the following:
tarantool/luajit@7b98314
If checkpatch doesn't blame this. If it is, maybe it's worth fixing the checkpatch first.
Feel free to ignore.
ylobankov
approved these changes
Nov 16, 2023
This test is no longer needed in the Tarantool test suite since it was added to LuaJIT's test suite along with the fix for the issue mentioned in tarantool#3060 in scope of tarantool#8825 in commit tarantool/luajit@7b98314. Closes tarantool#3060 Related to tarantool#8825 NO_DOC=Cleanup NO_TEST=Already included in LuaJIT bump NO_CHANGELOG=Already included in LuaJIT bump
mkokryashkin
force-pushed
the
fckxorg/remove-finalizers-test
branch
from
4668344
to
7db209d
Compare
igormunkin
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is no longer needed in the Tarantool test suite since it was added to LuaJIT's test suite along with the fix for the issue mentioned in #3060 in scope of #8825 in commit 7b98314e0dacc7313c061aceeb0a32afd4e8cbce ('Fix frame for more types of on-trace error messages.').
Closes #3060
Related to #8825
NO_DOC=Cleanup
NO_TEST=Already included in LuaJIT bump
NO_CHANGELOG=Already included in LuaJIT bump