Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of sqlite3NestedParse #3496

Closed
kyukhin opened this issue Jul 3, 2018 · 0 comments
Closed

Get rid of sqlite3NestedParse #3496

kyukhin opened this issue Jul 3, 2018 · 0 comments
Assignees
@kshcherbatov
Labels
refactoring Code refactoring sql
Milestone
2.1.0

Comments

@kyukhin
Copy link
Contributor

kyukhin commented Jul 3, 2018

This function was heavily used by legacy SQL code.
Now it is only used by sql_clear_stat_spaces.

Rewrite it to directly emit byte code, which will clear corresponding
entries in stat[14] tables.

This issue need to be solved before #3319, there should be no recursion.
@kyukhin kyukhin added refactoring Code refactoring sql labels Jul 3, 2018
@kyukhin kyukhin added this to the 2.1.0 milestone Jul 3, 2018
kshcherbatov added a commit that referenced this issue Jul 4, 2018
@kshcherbatov
sql: rid off sqlite3NestedParse in clean stats
da01a1e 
Now we manually generate AST structures to drop outdated
stats from _sql_stat1 and _sql_stat4 spaces instead of
starting sqlite3NestedParse. This function become totally
useless and could be removed.

Part of #3496.
kshcherbatov added a commit that referenced this issue Jul 4, 2018
@kshcherbatov
sql: remove usless sqlite3NestedParse function
da80e2d 
As sqlite3NestedParse become totaly useless, let's
remove unreacheble code and all mentioning.

Resolves #3496.
kshcherbatov added a commit that referenced this issue Jul 4, 2018
@kshcherbatov
sql: get rid off sqlite3NestedParse in clean stats
bd8d0b6 
Now we manually generate AST structures to drop outdated
stats from _sql_stat1 and _sql_stat4 spaces instead of
starting sqlite3NestedParse. This function become totally
useless and could be removed.

Part of #3496.
kshcherbatov added a commit that referenced this issue Jul 4, 2018
@kshcherbatov
sql: remove usless sqlite3NestedParse function
444b910 
As sqlite3NestedParse become totaly useless, let's
remove unreacheble code and all mentioning.

Resolves #3496.
Gerold103 pushed a commit that referenced this issue Jul 5, 2018
@kshcherbatov @Gerold103
sql: remove usless sqlite3NestedParse function
284b84d 
As sqlite3NestedParse become totaly useless, let's
remove unreacheble code and all mentioning.

Resolves #3496.
kshcherbatov added a commit that referenced this issue Jul 6, 2018
@kshcherbatov
sql: get rid off sqlite3NestedParse in clean stats
3017d0e 
Now we manually generate AST structures to drop outdated
stats from _sql_stat1 and _sql_stat4 spaces instead of
starting sqlite3NestedParse. This function become totally
useless and could be removed.

Part of #3496.
kshcherbatov added a commit that referenced this issue Jul 6, 2018
@kshcherbatov
sql: remove usless sqlite3NestedParse function
bfb8703 
As sqlite3NestedParse become totaly useless, let's
remove unreacheble code and all mentioning.

Resolves #3496.
Gerold103 pushed a commit that referenced this issue Jul 9, 2018
@kshcherbatov @Gerold103
sql: get rid off sqlite3NestedParse in clean stats
6a7d3aa 
Now we manually generate AST structures to drop outdated
stats from _sql_stat1 and _sql_stat4 spaces instead of
starting sqlite3NestedParse. This function become totally
useless and could be removed.

Part of #3496.
Gerold103 pushed a commit that referenced this issue Jul 9, 2018
@kshcherbatov @Gerold103
sql: remove usless sqlite3NestedParse function
f557be8 
As sqlite3NestedParse become totaly useless, let's
remove unreacheble code and all mentioning.

Resolves #3496.
kshcherbatov added a commit that referenced this issue Jul 11, 2018
@kshcherbatov
sql: get rid off sqlite3NestedParse in clean stats
c71cbea 
Now we manually generate AST structures to drop outdated
stats from _sql_stat1 and _sql_stat4 spaces instead of
starting sqlite3NestedParse. This function becomes totally
useless and could be removed.

Part of #3496.
kshcherbatov added a commit that referenced this issue Jul 11, 2018
@kshcherbatov
sql: remove usless sqlite3NestedParse function
9fc3298 
As sqlite3NestedParse became totaly useless, let's
remove unreacheble code and all mentioning.

Resolves #3496.
kshcherbatov added a commit that referenced this issue Jul 11, 2018
@kshcherbatov
sql: get rid off sqlite3NestedParse in clean stats
b261e8c 
Now we manually generate AST structures to drop outdated
stats from _sql_stat1 and _sql_stat4 spaces instead of
starting sqlite3NestedParse. This function becomes totally
useless and could be removed.

Part of #3496.
kshcherbatov added a commit that referenced this issue Jul 11, 2018
@kshcherbatov
sql: remove usless sqlite3NestedParse function
b6e57e0 
As sqlite3NestedParse became totaly useless, let's
remove unreacheble code and all mentioning.

Resolves #3496.
kshcherbatov added a commit that referenced this issue Jul 11, 2018
@kshcherbatov
sql: get rid off sqlite3NestedParse in clean stats
47e1e4d 
Now we manually generate AST structures to drop outdated
stats from _sql_stat1 and _sql_stat4 spaces instead of
starting sqlite3NestedParse. This function becomes totally
useless and could be removed.

Part of #3496.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kshcherbatov kshcherbatov

Labels
refactoring Code refactoring sql
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@kshcherbatov @kyukhin