Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

box.cfg ignores replicaset_uuid #4282

Closed
bofm opened this issue Jun 11, 2019 · 0 comments
Closed

box.cfg ignores replicaset_uuid #4282

bofm opened this issue Jun 11, 2019 · 0 comments
Assignees
@Gerold103
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
1.10.5

Comments

@bofm
Copy link

bofm commented Jun 11, 2019

Tarantool version: 2.2.0-128-g7b56f1fef

OS version: Alpine (official docker image)

Bug description:

box.cfg ignores some uuid-s when setting replicaset_uuid parameter. For example: 00000000-0000-0000-0000-000000000000

Steps to reproduce:

docker run --rm -it --entrypoint '' tarantool/tarantool:2 tarantool
Tarantool 2.2.0-128-g7b56f1fef
type 'help' for interactive help
tarantool> box.cfg{
         >     listen = 3301,
         >     wal_mode = "write",
         >     instance_uuid = 'aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa',
         >     replicaset_uuid = '00000000-0000-0000-0000-000000000000',
         > }
2019-06-11 17:42:02.304 [1] main/102/interactive C> Tarantool 2.2.0-128-g7b56f1fef
2019-06-11 17:42:02.304 [1] main/102/interactive C> log level 5
2019-06-11 17:42:02.304 [1] main/102/interactive I> mapping 268435456 bytes for memtx tuple arena...
2019-06-11 17:42:02.304 [1] main/102/interactive I> mapping 134217728 bytes for vinyl tuple arena...
2019-06-11 17:42:02.307 [1] main/102/interactive I> instance uuid aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa
2019-06-11 17:42:02.307 [1] iproto/101/main I> binary: bound to 0.0.0.0:3301
2019-06-11 17:42:02.307 [1] main/102/interactive I> initializing an empty data directory
2019-06-11 17:42:02.315 [1] main/102/interactive I> assigned id 1 to replica aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa
2019-06-11 17:42:02.315 [1] main/102/interactive I> cluster uuid e2f22730-dcd7-48d0-b05c-08b915b5f7b3
2019-06-11 17:42:02.316 [1] snapshot/101/main I> saving snapshot `./00000000000000000000.snap.inprogress'
2019-06-11 17:42:02.319 [1] snapshot/101/main I> done
2019-06-11 17:42:02.320 [1] main/102/interactive I> ready to accept requests
2019-06-11 17:42:02.320 [1] main/104/checkpoint_daemon I> scheduled next checkpoint for Tue Jun 11 18:43:31 2019
---
...

tarantool> box.info.uuid, box.info.cluster.uuid
---
- aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa
- e2f22730-dcd7-48d0-b05c-08b915b5f7b3
...

Desired behavior:
box.cfg should respect it's parameters and raise an error if the parameters are not valid. The parameters should not be ignored silently.
@kyukhin kyukhin added the bug Something isn't working label Jul 18, 2019
@kyukhin kyukhin added this to the 2.3.0 milestone Jul 18, 2019
@bofm bofm changed the title box.cfg ignores seplicaset_uuid box.cfg ignores replicaset_uuid Jul 18, 2019
@kostja kostja modified the milestones: 2.3.1, 1.10.4 Aug 6, 2019
@kostja kostja added the good first issue Good for newcomers label Aug 6, 2019
@MariaHajdic MariaHajdic self-assigned this Sep 5, 2019
Gerold103 added a commit that referenced this issue Sep 7, 2019
@Gerold103
box: raise an error on nil replicaset and instance uuid
b424e0e 
Before the patch the nil UUID was ignored and a new random one
was generated. This was because internally box treats nil UUID
as its absense.

Now a user will see an explicit message that nil UUID is a
reserved value.

Closes #4282
Gerold103 added a commit that referenced this issue Sep 7, 2019
@Gerold103
box: raise an error on nil replicaset and instance uuid
0c7e4a0 
Before the patch the nil UUID was ignored and a new random one
was generated. This was because internally box treats nil UUID
as its absence.

Now a user will see an explicit message that nil UUID is a
reserved value.

Closes #4282
Gerold103 added a commit that referenced this issue Sep 8, 2019
@Gerold103
box: raise an error on nil replicaset and instance uuid
a139f12 
Before the patch the nil UUID was ignored and a new random one
was generated. This was because internally box treats nil UUID
as its absence.

Now a user will see an explicit message that nil UUID is a
reserved value.

Closes #4282
@MariaHajdic MariaHajdic removed their assignment Sep 19, 2019
@Gerold103 Gerold103 self-assigned this Sep 19, 2019
@kyukhin kyukhin modified the milestones: 1.10.4, 1.10.5 Sep 26, 2019
kyukhin pushed a commit that referenced this issue Oct 28, 2019
@Gerold103 @kyukhin
box: raise an error on nil replicaset and instance uuid
708ca77 
Before the patch the nil UUID was ignored and a new random one
was generated. This was because internally box treats nil UUID
as its absence.

Now a user will see an explicit message that nil UUID is a
reserved value.

Closes #4282

(cherry picked from commit a8ebd33)
kyukhin pushed a commit that referenced this issue Oct 28, 2019
@Gerold103 @kyukhin
box: raise an error on nil replicaset and instance uuid
ff7d8f8 
Before the patch the nil UUID was ignored and a new random one
was generated. This was because internally box treats nil UUID
as its absence.

Now a user will see an explicit message that nil UUID is a
reserved value.

Closes #4282

(cherry picked from commit a8ebd33)
kyukhin pushed a commit that referenced this issue Oct 28, 2019
@Gerold103 @kyukhin
box: raise an error on nil replicaset and instance uuid
3685d69 
Before the patch the nil UUID was ignored and a new random one
was generated. This was because internally box treats nil UUID
as its absence.

Now a user will see an explicit message that nil UUID is a
reserved value.

Closes #4282

(cherry picked from commit a8ebd33)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gerold103 Gerold103

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
1.10.5
Development

No branches or pull requests
5 participants
@kostja @bofm @Gerold103 @kyukhin @MariaHajdic