Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4pt] build: enable out-of-source build on read-only file system #4874

Closed
avtikhon opened this issue Apr 10, 2020 · 7 comments
Closed

[4pt] build: enable out-of-source build on read-only file system #4874

avtikhon opened this issue Apr 10, 2020 · 7 comments
Assignees
@avtikhon
Projects
Quality Assurance
Milestone
2.6.2

Comments

@avtikhon
Copy link
Contributor

avtikhon commented Apr 10, 2020 •
edited by ligurio

No description provided.

@avtikhon avtikhon mentioned this issue Apr 10, 2020
Closed
@avtikhon
Copy link
Contributor Author

Waiting sub-task at:
curl/curl#5213

@avtikhon
Copy link
Contributor Author

Main activity at #4258

@avtikhon avtikhon added this to ON REVIEW in Quality Assurance Apr 21, 2020
@avtikhon avtikhon moved this from ON REVIEW to DOING in Quality Assurance Apr 21, 2020
@avtikhon avtikhon moved this from DOING to ON REVIEW in Quality Assurance Apr 21, 2020
@avtikhon avtikhon self-assigned this Apr 22, 2020
@ligurio
Copy link
Member

ligurio commented Apr 23, 2020

closed as main activity is in #4258

@ligurio ligurio closed this as completed Apr 23, 2020
@ligurio ligurio mentioned this issue Apr 23, 2020
Closed
@avtikhon avtikhon removed this from ON REVIEW in Quality Assurance Apr 23, 2020
@avtikhon avtikhon reopened this May 22, 2020
@avtikhon
Copy link
Contributor Author

Major task of the issue #4258 changed, so let's continue OOS build here

@avtikhon
Copy link
Contributor Author

For OOS build cURL build based on cmake is needed, check #4968

avtikhon added a commit that referenced this issue May 22, 2020
@avtikhon
Fix curl repository for out-of-source build
18007ef 
Temporary added branch in curl repository
with fix for out-of-source build.

Part of #4874
avtikhon added a commit that referenced this issue May 22, 2020
@avtikhon
Skip failing test from out-of-source build
f5757d8 
Skipped failing test app-tap/http_client.test.lua
from out-of-source build. Left #4258 issue opened
till it will be fixed.

Part of #4874
avtikhon added a commit that referenced this issue May 22, 2020
@avtikhon
gitlab-ci: add out-of-source build
181bb84 
Implemented out-of-source build at cmake files.
Added out of source build make targets and added
test job to gitlab-ci.

Part of #4874
@avtikhon avtikhon added this to DOING in Quality Assurance May 22, 2020
avtikhon added a commit that referenced this issue May 22, 2020
@avtikhon
gitlab-ci: add out-of-source build
376fc70 
Implemented out-of-source build at cmake files.
Added out of source build make targets and added
test job to gitlab-ci.

Closes #4874
@avtikhon avtikhon moved this from DOING to ON REVIEW in Quality Assurance May 22, 2020
@avtikhon avtikhon changed the title build: enable out-of-source build build: enable out-of-source build on RO file system May 23, 2020
@avtikhon avtikhon changed the title build: enable out-of-source build on RO file system build: enable out-of-source build on read-only file system May 23, 2020
avtikhon added a commit that referenced this issue May 23, 2020
@avtikhon
Fix curl repository for out-of-source build
454b270 
Temporary added branch in curl repository
with fix for out-of-source build.

Part of #4874
avtikhon added a commit that referenced this issue May 23, 2020
@avtikhon
Skip failing test from out-of-source build
131b27f 
Skipped failing test app-tap/http_client.test.lua
from out-of-source build. Left #4258 issue opened
till it will be fixed.

Part of #4874
avtikhon added a commit that referenced this issue May 23, 2020
@avtikhon
gitlab-ci: add out-of-source build
ff1eebe 
Implemented out-of-source build at cmake files.
Added out of source build make targets and added
test job to gitlab-ci.

Closes #4874
avtikhon added a commit that referenced this issue May 26, 2020
@avtikhon
Fix curl repository for out-of-source build
5990ca9 
Temporary added branch in curl repository
with fix for out-of-source build.

Part of #4874
avtikhon added a commit that referenced this issue May 26, 2020
@avtikhon
Skip failing test from out-of-source build
cf62730 
Skipped failing test app-tap/http_client.test.lua
from out-of-source build. Left #4258 issue opened
till it will be fixed.

Part of #4874
avtikhon added a commit that referenced this issue May 26, 2020
@avtikhon
gitlab-ci: add out-of-source build
add6c5b 
Implemented out-of-source build at cmake files.
Added out of source build make targets and added
test job to gitlab-ci.

Closes #4874
@avtikhon
Copy link
Contributor Author

Depends on #4968

avtikhon added a commit that referenced this issue May 26, 2020
@avtikhon
Fix curl repository for out-of-source build
0be0350 
Temporary added branch in curl repository
with fix for out-of-source build.

Part of #4874
avtikhon added a commit that referenced this issue Sep 17, 2020
@avtikhon
gitlab-ci: add out-of-source build
39f366f 
Implemented out-of-source build at cmake files.
Added out of source build make targets and added
test job to gitlab-ci.

Closes #4874
avtikhon added a commit that referenced this issue Sep 23, 2020
@avtikhon
gitlab-ci: add out-of-source build
3790b1b 
Implemented out-of-source build at cmake files.
Added out of source build make targets and added
test job to gitlab-ci.

Closes #4874
@kyukhin kyukhin changed the title build: enable out-of-source build on read-only file system [4pt] build: enable out-of-source build on read-only file system Sep 25, 2020
avtikhon added a commit that referenced this issue Oct 6, 2020
@avtikhon
gitlab-ci: add out-of-source build
46100bf 
Implemented out-of-source build at cmake files.
Added out of source build make targets and added
test job to gitlab-ci.

Closes #4874
avtikhon added a commit that referenced this issue Oct 8, 2020
@avtikhon
gitlab-ci: add out-of-source build
b272110 
Implemented out-of-source build at cmake files.
Added out of source build make targets and added
test job to gitlab-ci.

Closes #4874
avtikhon added a commit that referenced this issue Oct 8, 2020
@avtikhon
gitlab-ci: add out-of-source build
003d388 
Implemented out-of-source build at cmake files.
Added out of source build make targets and added
test job to gitlab-ci.

Closes #4874
avtikhon added a commit that referenced this issue Oct 8, 2020
@avtikhon
gitlab-ci: add out-of-source build
4996f2a 
Implemented out-of-source build at cmake files.
Added out of source build make targets and added
test job to gitlab-ci.

Closes #4874
avtikhon added a commit that referenced this issue Oct 12, 2020
@avtikhon
gitlab-ci: add out-of-source build
62eca1f 
Implemented out-of-source build at cmake files.
Added out of source build make targets and added
test job to gitlab-ci.

Closes #4874
avtikhon added a commit that referenced this issue Oct 13, 2020
@avtikhon
gitlab-ci: add out-of-source build
8b8d369 
Implemented out-of-source build at cmake files.
Added out of source build make targets and added
test job to gitlab-ci.

Closes #4874
avtikhon added a commit that referenced this issue Oct 14, 2020
@avtikhon
gitlab-ci: add out-of-source build
7ab1230 
Implemented out-of-source build at cmake files. Added out of source
build make targets and added test job to gitlab-ci.

Closes #4874
avtikhon added a commit that referenced this issue Oct 14, 2020
@avtikhon
gitlab-ci: add out-of-source build
dcdcc16 
Implemented out-of-source build at cmake files. Added out of source
build make targets and added test job to gitlab-ci.

Closes #4874
avtikhon added a commit that referenced this issue Oct 14, 2020
@avtikhon
gitlab-ci: add out-of-source build
03ab101 
Implemented out-of-source build at cmake files. Added out of source
build make targets and added test job to gitlab-ci.

Closes #4874
avtikhon added a commit that referenced this issue Oct 15, 2020
@avtikhon
gitlab-ci: add out-of-source build
9f71185 
Added out of source build make targets and added test job to gitlab-ci.

Closes #4874
avtikhon added a commit that referenced this issue Oct 15, 2020
@avtikhon
gitlab-ci: add out-of-source build
e3f884f 
Added out of source build make targets and added test job to gitlab-ci.

Closes #4874
avtikhon added a commit that referenced this issue Oct 15, 2020
@avtikhon
gitlab-ci: add out-of-source build
589703e 
Added out of source build make targets and added test job to gitlab-ci.

Closes #4874
avtikhon added a commit that referenced this issue Oct 15, 2020
@avtikhon
gitlab-ci: add out-of-source build
6481a3d 
Added out of source build make targets and added test job to gitlab-ci.

Closes #4874
avtikhon added a commit that referenced this issue Oct 15, 2020
@avtikhon
gitlab-ci: add out-of-source build
20674da 
Added out of source build make targets and added test job to gitlab-ci.

Closes #4874
avtikhon added a commit that referenced this issue Oct 15, 2020
@avtikhon
gitlab-ci: add out-of-source build
82e7b21 
Added out of source build make targets and added test job to gitlab-ci.

Closes #4874
avtikhon added a commit that referenced this issue Oct 16, 2020
@avtikhon
gitlab-ci: add out-of-source build
3009805 
Added out of source build make targets and added test job to gitlab-ci.

Closes #4874
@avtikhon avtikhon moved this from ON REVIEW to ON REVIEW WITH 1 LGTM in Quality Assurance Oct 16, 2020
avtikhon added a commit that referenced this issue Oct 21, 2020
@avtikhon
test-run: bump test-run for *.reject files
ee873fa 
Changed the path for saving *.reject files, for now it is saving in the
'<vardir>/rejects/<suite>' subfolder given in options or set localy as
'var/rejects/<suite>' by default.

Needed for #4874
avtikhon added a commit that referenced this issue Oct 21, 2020
@avtikhon
test-run: bump test-run for *.reject files
1b867f7 
Changed the path for saving *.reject files, for now it is saving in the
'<vardir>/rejects/<suite>' subfolder given in options or set localy as
'var/rejects/<suite>' by default.

Needed for #4874
Totktonada added a commit that referenced this issue Oct 30, 2020
@Totktonada
test: update test-run
8a0d45f 
Store *.reject files in ${BUILD}/test/var/rejects/<...>/ instead of
${SOURCE}/test/<...>/.

The past approach leads to problems with testing, when the out of source
build is used and sources are on a read-only filesystem. The main
problem is when a test fails, but it is marked as fragile and should be
run again. The test fail assumes storing of the .reject file and the
testing fails on attempt to write to the read-only filesystem. The
re-run is not performed so.

Side effect for the in-source build: since the test/var/ directory is
gitignored, the *.reject files will not shown in `git status` output
anymore.

tarantool/test-run#209

Follows up #4874
Totktonada added a commit that referenced this issue Oct 30, 2020
@Totktonada
test: update test-run
f6dfdc1 
Store *.reject files in ${BUILD}/test/var/rejects/<...>/ instead of
${SOURCE}/test/<...>/.

The past approach leads to problems with testing, when the out of source
build is used and sources are on a read-only filesystem. The main
problem is when a test fails, but it is marked as fragile and should be
run again. The test fail assumes storing of the .reject file and the
testing fails on attempt to write to the read-only filesystem. The
re-run is not performed so.

Side effect for the in-source build: since the test/var/ directory is
gitignored, the *.reject files will not shown in `git status` output
anymore.

tarantool/test-run#209

Follows up #4874

(cherry picked from commit 8a0d45f)
Totktonada added a commit that referenced this issue Oct 30, 2020
@Totktonada
test: update test-run
7366da9 
Store *.reject files in ${BUILD}/test/var/rejects/<...>/ instead of
${SOURCE}/test/<...>/.

The past approach leads to problems with testing, when the out of source
build is used and sources are on a read-only filesystem. The main
problem is when a test fails, but it is marked as fragile and should be
run again. The test fail assumes storing of the .reject file and the
testing fails on attempt to write to the read-only filesystem. The
re-run is not performed so.

Side effect for the in-source build: since the test/var/ directory is
gitignored, the *.reject files will not shown in `git status` output
anymore.

tarantool/test-run#209

Follows up #4874

(cherry picked from commit 8a0d45f)
Totktonada added a commit that referenced this issue Oct 30, 2020
@Totktonada
test: update test-run
074b73f 
Store *.reject files in ${BUILD}/test/var/rejects/<...>/ instead of
${SOURCE}/test/<...>/.

The past approach leads to problems with testing, when the out of source
build is used and sources are on a read-only filesystem. The main
problem is when a test fails, but it is marked as fragile and should be
run again. The test fail assumes storing of the .reject file and the
testing fails on attempt to write to the read-only filesystem. The
re-run is not performed so.

Side effect for the in-source build: since the test/var/ directory is
gitignored, the *.reject files will not shown in `git status` output
anymore.

tarantool/test-run#209

Follows up #4874

(cherry picked from commit 8a0d45f)
@Totktonada Totktonada mentioned this issue Oct 30, 2020
Merged
@kyukhin kyukhin modified the milestones: wishlist, 2.6.2 Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avtikhon avtikhon

Labels
None yet
Projects
No open projects
Quality Assurance
ON REVIEW WITH 1 LGTM
Milestone
2.6.2
Development

No branches or pull requests
4 participants
@ligurio @rosik @kyukhin @avtikhon