Closed
Conversation
Member
|
I don't understand the description. You want to fix out-of-tree builds. But why is storing a temp file in "current directory" a problem for those? In most cases, that's exactly where you want the files to be made as that's the place you build as compared to where the source lives. I'm not against the fix, I like avoiding a tempfile, I just have a problem to understand the explanation! |
Member
|
Thanks. I modified the commit message before merging because of what I mentioned above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use to build Curl sources in our project and wanted to have out-of-source build. To make it able we need to avoid of use the current paths. In Curl sources we found this single place where for cleanup the current path was used for temporary files. We can suggest to avoid of its use and run 'find' command to find and remove needed files.
Need for tarantool/tarantool#4874