Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change for out-of-source build #5213

Closed

Conversation

@avtikhon
Copy link
Contributor

@avtikhon avtikhon commented Apr 10, 2020

We use to build Curl sources in our project and wanted to have out-of-source build. To make it able we need to avoid of use the current paths. In Curl sources we found this single place where for cleanup the current path was used for temporary files. We can suggest to avoid of its use and run 'find' command to find and remove needed files.
Need for tarantool/tarantool#4874

@bagder
Copy link
Member

@bagder bagder commented Apr 10, 2020

I don't understand the description. You want to fix out-of-tree builds. But why is storing a temp file in "current directory" a problem for those? In most cases, that's exactly where you want the files to be made as that's the place you build as compared to where the source lives.

I'm not against the fix, I like avoiding a tempfile, I just have a problem to understand the explanation!

@bagder bagder added the build label Apr 10, 2020
@bagder bagder closed this in 1e41bec Apr 15, 2020
@bagder
Copy link
Member

@bagder bagder commented Apr 15, 2020

Thanks. I modified the commit message before merging because of what I mentioned above.

avtikhon added a commit to tarantool/curl that referenced this pull request May 23, 2020
Copied from: "Fixed in 7.70.0 - April 29 2020"
  curl#5213

Closes curl#5213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.