Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of serpent module #5517

Closed
cyrillos opened this issue Nov 13, 2020 · 0 comments
Closed

get rid of serpent module #5517

cyrillos opened this issue Nov 13, 2020 · 0 comments
Assignees
@cyrillos
Labels
refactoring Code refactoring

Comments

@cyrillos
Copy link
Contributor

Since the commit ae7e210 we use internal serializator because serpent unable to work with our internal types (see #4682). Thus we no longer need it and should drop off from the source code.
@cyrillos cyrillos self-assigned this Nov 13, 2020
@cyrillos cyrillos added the refactoring Code refactoring label Nov 13, 2020
cyrillos added a commit that referenced this issue Nov 13, 2020
@cyrillos
console: drop unused serpent module
d629ec2 
Since the commit ae7e210 we use internal serializer
thus we no longer need serpent code.

The patch removes the references from the source code
and .gitmodules file, still one might need to run

 | git submodule deinit -f third_party/serpent

manually to clean up the working tree depending
on local git version.

Closes #5517

Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cyrillos cyrillos

Labels
refactoring Code refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cyrillos