Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignoring part type options when type is omitted #5674

Closed
mary3000 opened this issue Dec 30, 2020 · 0 comments
Closed

Ignoring part type options when type is omitted #5674

mary3000 opened this issue Dec 30, 2020 · 0 comments
Assignees
@mary3000
Labels
bug Something isn't working
Milestone
2.7.2

Comments

@mary3000
Copy link
Contributor

From comment on pull request:
If you create index without explicitly stating its part type, then part type options will be ignored. Example:

s = box.schema.space.create('test')
s:create_index('pk', {parts = {1, 'int'}})
s:create_index('sk', {parts = {2, is_nullable=true}})

will result in is_nullable == false in sk.

Such index definition should be disallowed or should be supported but with correct option processing.
@mary3000 mary3000 added the bug Something isn't working label Dec 30, 2020
@mary3000 mary3000 self-assigned this Dec 30, 2020
mary3000 added a commit that referenced this issue Jan 19, 2021
@mary3000
index: fix omitting index part options when type is missing
6fbc894 
previously such code:
s = box.schema.space.create('test')
s:create_index('pk', {parts = {1, 'int'}})
s:create_index('sk', {parts = {2, is_nullable=true}})

was resulting in is_nullable=false, which is wrong

Closes #5674
@mary3000 mary3000 mentioned this issue Jan 19, 2021
Closed
mary3000 added a commit that referenced this issue Feb 10, 2021
@mary3000
index: fix omitting index part options when type is missing
dc0cc4b 
previously such code:
s = box.schema.space.create('test')
s:create_index('pk', {parts = {1, 'int'}})
s:create_index('sk', {parts = {2, is_nullable=true}})

was resulting in is_nullable=false, which is wrong

Closes #5674
Korablev77 pushed a commit that referenced this issue Feb 12, 2021
@mary3000 @Korablev77
index: fix omitting index part options when type is missing
c0ee7b6 
previously such code:
s = box.schema.space.create('test')
s:create_index('pk', {parts = {1, 'int'}})
s:create_index('sk', {parts = {2, is_nullable=true}})

was resulting in is_nullable=false, which is wrong

Closes #5674
@kyukhin kyukhin added this to the 2.7.2 milestone Feb 12, 2021
@kyukhin kyukhin added the teamC label Feb 12, 2021
Korablev77 pushed a commit that referenced this issue Feb 12, 2021
@mary3000 @Korablev77
index: fix omitting index part options when type is missing
6445008 
previously such code:
s = box.schema.space.create('test')
s:create_index('pk', {parts = {1, 'int'}})
s:create_index('sk', {parts = {2, is_nullable=true}})

was resulting in is_nullable=false, which is wrong

Closes #5674

(cherry picked from commit de6c76b)
@alyapunov alyapunov added the 3sp label Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mary3000 mary3000

Labels
bug Something isn't working
Projects
None yet
Milestone
2.7.2
Development

Successfully merging a pull request may close this issue.

index: fix omitting index part options when type is missing tarantool/tarantool
3 participants
@alyapunov @kyukhin @mary3000