Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid error message on box.schema.user.grant() #714

Closed
rtsisyk opened this issue Feb 4, 2015 · 0 comments
Closed

Invalid error message on box.schema.user.grant() #714

rtsisyk opened this issue Feb 4, 2015 · 0 comments
Assignees
@MariaHajdic
Labels
bug Something isn't working
Milestone
2.4.1

Comments

@rtsisyk
Copy link
Contributor

rtsisyk commented Feb 4, 2015 

tarantool> box.schema.user.create('tester')
2015-02-04 17:36:15.033 [23043] wal I> creating `./00000000000000000000.xlog.inprogress'

---
...

tarantool> box.schema.user.grant('tester', 'read,write,execute', 'universe')

---
...

tarantool> box.schema.user.grant('tester', 'read,write,execute', 'universe')

---
- error: User 'tester' already has read,write,execute access on universe 'nil'
...
@kostja kostja added this to the 1.6.7 milestone Feb 5, 2015
@kostja kostja modified the milestones: 1.6.7, 1.7 Aug 31, 2015
@kostja kostja added the bug Something isn't working label Aug 31, 2015
MariaHajdic added a commit that referenced this issue Feb 12, 2020
@MariaHajdic
box: user.grant error should be versatile
013a282 
Error message on granted privileges was not flexible and
did not distinguish between universal or any other priviliges.

Closes #714
@MariaHajdic MariaHajdic self-assigned this Feb 16, 2020
MariaHajdic added a commit that referenced this issue Feb 19, 2020
@MariaHajdic
box: user.grant error should be versatile
a5076d7 
Error message on granted privileges was not flexible and
did not distinguish between universal or any other priviliges
leaving either 'nil' or simply '' at the end.

Closes #714
MariaHajdic added a commit that referenced this issue Feb 20, 2020
@MariaHajdic
box: user.grant error should be versatile
3a28f0b 
Error message on granted privileges was not flexible and
did not distinguish between universal or any other priviliges
leaving either 'nil' or simply '' at the end.

Closes #714
MariaHajdic added a commit that referenced this issue Feb 20, 2020
@MariaHajdic
box: user.grant error should be versatile
67000f5 
Error message on granted privileges was not flexible and
did not distinguish between universal or any other privileges
leaving either 'nil' or simply '' at the end.

Closes #714
MariaHajdic added a commit that referenced this issue Feb 25, 2020
@MariaHajdic
box: user.grant error should be versatile
28f1f4b 
Error message on granted privileges was not flexible and
did not distinguish between universal or any other privileges
leaving either 'nil' or simply '' at the end.

Closes #714
@kyukhin kyukhin modified the milestones: wishlist, 2.4.1 Feb 25, 2020
MariaHajdic added a commit that referenced this issue Feb 26, 2020
@MariaHajdic
box: user.grant error should be versatile - follow up
ac0475f 
Previous commit that was merged into master did not do
proper clean-up. That caused occasional failures of other
tests, all with the same error saying user 'guest' already
had access on universe.

Closes #714
Totktonada pushed a commit that referenced this issue Feb 27, 2020
@MariaHajdic @Totktonada
test: add clean up for box/access test
e33216a 
The commit e8009f4 ('box: user.grant
error should be versatile') did not do proper clean-up: it grants
non-default privileges for user 'guest' and does not revoke them at the
end. That caused occasional failures of other tests, all with the same
error saying user 'guest' already had access on universe.

This case should be handled by test-run in a future, see [1].

[1]: tarantool/test-run#156

Follows up #714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MariaHajdic MariaHajdic

Labels
bug Something isn't working
Projects
None yet
Milestone
2.4.1
Development

No branches or pull requests
4 participants
@kostja @rtsisyk @kyukhin @MariaHajdic