sysprof and memprof parsers lack error handling #9217

mkokryashkin · 2023-10-04T11:49:19Z

Bug description

OS: Linux
OS Version: any
Architecture: x86_64

Both the sysprof and memprof parsers lack thorough error handling. It results in raw lua errors for all kinds of situations: incorrect file passed, file being corrupted, empty, etc. Below are some examples of the errors mentioned:

$ ./build/src/luajit -ts sysprof.bin
$ file sysprof.bin
sysprof.bin: empty
$ ./build/src/luajit -ts sysprof.bin
./build/src/luajit: ./tools/utils/symtab.lua:107: attempt to concatenate local 'magic' (a nil value)

$  ./build/src/luajit -ts mee
./build/src/luajit: ./tools/utils/bufread.lua:122: fopen, errno: 2

Expected behavior

Parsers should be refactored so all possible errors are reported in a concise and user-friendly way. Maybe it would be nice to provide some possible solutions along with errors. No raw Lua errors must be thrown.

The text was updated successfully, but these errors were encountered:

igormunkin · 2023-11-22T14:06:46Z

Looks like part of #5994.

Prior to this patch, there was no error-checking in profilers, which resulted in raw Lua errors being reported in cases of non-existing paths or corrupt file structures. This patch adds error handling, so all parsing errors are now reported in a user-friendly manner. Event parsing is now moved into a separate profiler-agnostic module. Tool CLI flag tests are adapted correspondingly to error message changes. Resolves tarantool/tarantool#9217 Part of tarantool/tarantool#5994

sysprof: purge `collapse.lua` profilers: print user-friendly errors memprof: introduce the `--human-readable` option memprof: refactor `heap_chunk` data structure cmake: properly handle the memprof/process.lua Closes tarantool#9217 Part of tarantool#5994 Part of tarantool#8700 NO_DOC=LJ NO_TEST=LJ

profilers: print user-friendly errors memprof: introduce the `--human-readable` option memprof: refactor `heap_chunk` data structure cmake: properly handle the memprof/process.lua Closes tarantool#9217 Part of tarantool#5994 Part of tarantool#8700 NO_DOC=LJ NO_TEST=LJ

Prior to this patch, there was no error-checking in profilers, which resulted in raw Lua errors being reported in cases of non-existing paths or corrupt file structures. This patch adds error handling, so all parsing errors are now reported in a user-friendly manner. Event parsing is now moved into a separate profiler-agnostic module. Tool CLI flag tests are adapted correspondingly to error message changes. Resolves tarantool/tarantool#9217 Part of tarantool/tarantool#5994

profilers: print user-friendly errors memprof: introduce the `--human-readable` option memprof: refactor `heap_chunk` data structure cmake: properly handle the memprof/process.lua Closes tarantool#9217 Part of tarantool#5994 Part of tarantool#8700 NO_DOC=LJ NO_TEST=LJ

Prior to this patch, there was no error-checking in profilers, which resulted in raw Lua errors being reported in cases of non-existing paths or corrupt file structures. This patch adds error handling, so all parsing errors are now reported in a user-friendly manner. Event parsing is now moved into a separate profiler-agnostic module. Tool CLI flag tests are adapted correspondingly to error message changes. Resolves tarantool/tarantool#9217 Part of tarantool/tarantool#5994

profilers: print user-friendly errors memprof: introduce the `--human-readable` option memprof: refactor `heap_chunk` data structure cmake: properly handle the memprof/process.lua Closes tarantool#9217 Part of tarantool#5994 Part of tarantool#8700 NO_DOC=LJ NO_TEST=LJ

Prior to this patch, there was no error-checking in profilers, which resulted in raw Lua errors being reported in cases of non-existing paths or corrupt file structures. This patch adds error handling, so all parsing errors are now reported in a user-friendly manner. Event parsing is now moved into a separate profiler-agnostic module. Tool CLI flag tests are adapted correspondingly to error message changes. Resolves tarantool/tarantool#9217 Part of tarantool/tarantool#5994

profilers: print user-friendly errors memprof: introduce the `--human-readable` option memprof: refactor `heap_chunk` data structure cmake: properly handle the memprof/process.lua Closes tarantool#9217 Part of tarantool#5994 Part of tarantool#8700 NO_DOC=LJ NO_TEST=LJ

profilers: print user-friendly errors memprof: introduce the `--human-readable` option memprof: remove unused arguments memprof: refactor `heap_chunk` data structure build: fix tool components handling build: purge sysprof.collapse module Closes tarantool#9217 Part of tarantool#5994 Part of tarantool#8700 NO_DOC=LJ NO_TEST=LJ

Prior to this patch, there was no error-checking in profilers, which resulted in raw Lua errors being reported in cases of non-existing paths or corrupt file structures. This patch adds error handling, so all parsing errors are now reported in a user-friendly manner. Event parsing is now moved into a separate profiler-agnostic module. Tool CLI flag tests are adapted correspondingly to error message changes. Resolves tarantool/tarantool#9217 Part of tarantool/tarantool#5994

profilers: print user-friendly errors memprof: introduce the `--human-readable` option memprof: remove unused arguments memprof: refactor `heap_chunk` data structure build: fix tool components handling build: purge sysprof.collapse module Closes tarantool#9217 Part of tarantool#5994 Part of tarantool#8700 NO_DOC=LJ NO_TEST=LJ

Prior to this patch, there was no error-checking in profilers, which resulted in raw Lua errors being reported in cases of non-existing paths or corrupt file structures. This patch adds error handling, so all parsing errors are now reported in a user-friendly manner. Event parsing is now moved into a separate profiler-agnostic module. Tool CLI flag tests are adapted correspondingly to error message changes. Resolves tarantool/tarantool#9217 Part of tarantool/tarantool#5994

profilers: print user-friendly errors memprof: introduce the `--human-readable` option memprof: remove unused arguments memprof: refactor `heap_chunk` data structure build: fix tool components handling build: purge sysprof.collapse module Closes tarantool#9217 Part of tarantool#5994 Part of tarantool#8700 NO_DOC=LJ NO_TEST=LJ

Prior to this patch, there was no error-checking in profilers, which resulted in raw Lua errors being reported in cases of non-existing paths or corrupt file structures. This patch adds error handling, so all parsing errors are now reported in a user-friendly manner. Event parsing is now moved into a separate profiler-agnostic module. Tool CLI flag tests are adapted correspondingly to error message changes. Resolves tarantool/tarantool#9217 Part of tarantool/tarantool#5994

There is no error-checking in profilers which results in raw Lua errors being reported in cases of non-existing paths or corrupt file structures. This patch adds a profiler-agnostic module for event parsing, which is going to be used to introduce user-friendly errors. It is impossible to enable it right now because it should be included in Tarantool's build procedure first. Part of tarantool/tarantool#9217 Part of tarantool/tarantool#5994

profilers: introduce event reader module memprof: introduce the `--human-readable` option memprof: remove unused arguments memprof: refactor `heap_chunk` data structure build: fix tool components handling build: purge sysprof.collapse module Part of tarantool#9217 Part of tarantool#5994 Part of tarantool#8700 NO_DOC=LJ NO_TEST=LJ

There is no error-checking in profilers which results in raw Lua errors being reported in cases of non-existing paths or corrupt file structures. This patch adds a profiler-agnostic module for event parsing, which is going to be used to introduce user-friendly errors. It is impossible to enable it right now because it should be included in Tarantool's build procedure first. Part of tarantool/tarantool#9217 Part of tarantool/tarantool#5994

There is no error-checking in profilers which results in raw Lua errors being reported in cases of non-existing paths or corrupt file structures. This patch adds a profiler-agnostic module for event parsing, which is going to be used to introduce user-friendly errors. It is impossible to enable it right now because it should be included in Tarantool's build procedure first. Part of tarantool/tarantool#9217 Part of tarantool/tarantool#5994 Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org> Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Signed-off-by: Sergey Kaplun <skaplun@tarantool.org>

There is no error-checking in profilers which results in raw Lua errors being reported in cases of non-existing paths or corrupt file structures. This patch adds a profiler-agnostic module for event parsing, which is going to be used to introduce user-friendly errors. It is impossible to enable it right now because it should be included in Tarantool's build procedure first. Part of tarantool/tarantool#9217 Part of tarantool/tarantool#5994 Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org> Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Signed-off-by: Sergey Kaplun <skaplun@tarantool.org> (cherry picked from commit df5a072)

This patch adds necessary cmake configurations for the <evread.lua> module, so it can be used later to implement human-readable error reporting in profile parsers. Part of tarantool#9217 NO_DOC=LJ NO_TEST=LJ NO_CHANGELOG=build

This patch adds necessary cmake configurations for the <evread.lua> module, so it can be used later to implement human-readable error reporting in profile parsers. Part of tarantool#9217 NO_DOC=LuaJIT submodule NO_TEST=covered by the LuaJIT tests NO_CHANGELOG=build

This patch adds necessary cmake configurations for the <evread.lua> module, so it can be used later to implement human-readable error reporting in profile parsers. Part of #9217 NO_DOC=LuaJIT submodule NO_TEST=covered by the LuaJIT tests NO_CHANGELOG=build

This patch adds necessary cmake configurations for the <evread.lua> module, so it can be used later to implement human-readable error reporting in profile parsers. Part of tarantool#9217 NO_DOC=LuaJIT submodule NO_TEST=covered by the LuaJIT tests NO_CHANGELOG=build (cherry picked from commit e01fe8f)

Prior to this patch, there was no error-checking in profilers, which resulted in raw Lua errors being reported in cases of non-existing paths or corrupt file structures. This patch makes use of the event reader module introduced in commit df5a072 ("profilers: introduce event reader module") to add error handling, so all parsing errors are now reported in a user-friendly manner. Tool CLI flag tests are adapted correspondingly to error message changes. Resolves tarantool/tarantool#9217 Part of tarantool/tarantool#5994

This patch adds necessary cmake configurations for the <evread.lua> module, so it can be used later to implement human-readable error reporting in profile parsers. Part of #9217 NO_DOC=LuaJIT submodule NO_TEST=covered by the LuaJIT tests NO_CHANGELOG=build (cherry picked from commit e01fe8f)

Prior to this patch, there was no error-checking in profilers, which resulted in raw Lua errors being reported in cases of non-existing paths or corrupt file structures. This patch makes use of the event reader module introduced in commit df5a072 ("profilers: introduce event reader module") to add error handling, so all parsing errors are now reported in a user-friendly manner. Tool CLI flag tests are adapted correspondingly to error message changes. Resolves tarantool/tarantool#9217 Part of tarantool/tarantool#5994

Prior to this patch, there was no error-checking in profilers, which resulted in raw Lua errors being reported in cases of non-existing paths or corrupt file structures. This patch makes use of the event reader module introduced in commit df5a072 ("profilers: introduce event reader module") to add error handling, so all parsing errors are now reported in a user-friendly manner. Tool CLI flag tests are adapted correspondingly to error message changes. Resolves tarantool/tarantool#9217 Part of tarantool/tarantool#5994 Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org> Signed-off-by: Sergey Kaplun <skaplun@tarantool.org> (cherry picked from commit ecc4535)

* ci: bump version of actions/checkout * test: fix typo in the link to the issue * test: refactor CMake macro LibRealPath * test: move LibRealPath to the separate module * test: more cautious usage of LD_PRELOAD for ASan * test: fix lj-802-panic-at-mcode-protfail GCC+ASan * ci: execute LuaJIT tests with GCC 10 and ASAN * cmake: replace prove with CTest * Prevent down-recursion for side traces. * Handle stack reallocation in debug.setmetatable() and lua_setmetatable(). * profilers: print user-friendly errors Closes tarantool#5994 Closes tarantool#9595 Closes tarantool#9217 Closes tarantool#9656 NO_DOC=LuaJIT submodule bump NO_TEST=LuaJIT submodule bump

* ci: bump version of actions/checkout * test: fix typo in the link to the issue * test: refactor CMake macro LibRealPath * test: move LibRealPath to the separate module * test: more cautious usage of LD_PRELOAD for ASan * test: fix lj-802-panic-at-mcode-protfail GCC+ASan * ci: execute LuaJIT tests with GCC 10 and ASAN * cmake: replace prove with CTest * Prevent down-recursion for side traces. * Handle stack reallocation in debug.setmetatable() and lua_setmetatable(). * profilers: print user-friendly errors Closes #5994 Closes #9595 Closes #9217 Closes #9656 NO_DOC=LuaJIT submodule bump NO_TEST=LuaJIT submodule bump

mkokryashkin added bug Something isn't working luajit labels Oct 4, 2023

mkokryashkin self-assigned this Oct 4, 2023

mkokryashkin mentioned this issue Dec 3, 2023

luajit: bump new version #9438

Closed

mkokryashkin mentioned this issue Mar 21, 2024

build: add CMake configuration for evread module #9853

Merged

mkokryashkin mentioned this issue Mar 26, 2024

[backport/release/3.0] build: add CMake configuration for evread module #9873

Merged

mkokryashkin mentioned this issue Mar 26, 2024

[backport/release/2.11] build: add CMake configuration for evread module #9874

Merged

Buristan mentioned this issue Apr 4, 2024

Memprof parser refactoring #5994

Closed

3 tasks

Buristan closed this as completed in tarantool/luajit@ecc4535 Apr 8, 2024

This was referenced Apr 11, 2024

luajit: bump new version #9938

Merged

[backport/release/3.0] luajit: bump new version #9939

Merged

[backport/release/2.11] luajit: bump new version #9940

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sysprof and memprof parsers lack error handling #9217

sysprof and memprof parsers lack error handling #9217

mkokryashkin commented Oct 4, 2023

igormunkin commented Nov 22, 2023

sysprof and memprof parsers lack error handling #9217

sysprof and memprof parsers lack error handling #9217

Comments

mkokryashkin commented Oct 4, 2023

igormunkin commented Nov 22, 2023