build: add CMake configuration for evread module #9853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buristan
added
full-ci
Buristan
approved these changes
Mar 23, 2024
mkokryashkin
force-pushed
the
fckxorg/profile-parsers-refactoring
branch
2 times, most recently
from
200a6cb
to
597d408
Compare
Thanks for the comment! Fixed for places where order is insignificant. |
ligurio
reviewed
Mar 25, 2024
ligurio
approved these changes
Mar 25, 2024
This patch adds necessary cmake configurations for the <evread.lua> module, so it can be used later to implement human-readable error reporting in profile parsers. Part of tarantool#9217 NO_DOC=LuaJIT submodule NO_TEST=covered by the LuaJIT tests NO_CHANGELOG=build
mkokryashkin
force-pushed
the
fckxorg/profile-parsers-refactoring
branch
from
597d408
to
84101f0
Compare
Fixed, thanks |
ligurio
approved these changes
Mar 26, 2024
ylobankov
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds necessary cmake configurations for the <evread.lua> module, so it can be used later to implement human-readable error reporting in profile parsers.
Part of #9217
NO_DOC=LJ
NO_TEST=LJ
NO_CHANGELOG=build