Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add tt weak dependency #8484

Merged
merged 1 commit into from
Mar 24, 2023
Merged

build: add tt weak dependency #8484

merged 1 commit into from
Mar 24, 2023

Conversation

psergee
Copy link
Contributor

@psergee psergee commented Mar 22, 2023 •
edited by ylobankov
Loading

No description provided.

@psergee psergee force-pushed the psergee/no-gh-add-tt-dependency branch from 4f75a84 to f2cdc65 Compare March 22, 2023 14:27
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration /language:cpp. As part of the setup process, we have scanned this repository and found 21 existing alerts. Please check the repository Security tab to see all alerts.

@coveralls
Copy link

coveralls commented Mar 22, 2023 •
edited
Loading

Coverage Status

Coverage: 85.657% (+0.04%) from 85.618% when pulling 24cf626 on psergee/no-gh-add-tt-dependency into 8f95eaa
on master.

Totktonada
Totktonada reviewed Mar 22, 2023
View reviewed changes
debian/control Outdated Show resolved Hide resolved
Totktonada
Totktonada reviewed Mar 22, 2023
View reviewed changes
rpm/tarantool.spec Outdated Show resolved Hide resolved
@psergee psergee force-pushed the psergee/no-gh-add-tt-dependency branch from f2cdc65 to 51b4a27 Compare March 23, 2023 09:50
LeonidVas
LeonidVas reviewed Mar 23, 2023
View reviewed changes
Copy link
Contributor

@LeonidVas LeonidVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for the patch.

rpm/tarantool.spec Outdated Show resolved Hide resolved
@psergee psergee force-pushed the psergee/no-gh-add-tt-dependency branch from 51b4a27 to c7c94f7 Compare March 23, 2023 18:57
@psergee psergee marked this pull request as ready for review March 23, 2023 18:58
LeonidVas
LeonidVas approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@LeonidVas LeonidVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psergee psergee requested a review from Totktonada March 24, 2023 13:13
@psergee
build: add tt weak dependency
24cf626 
Part of tarantool/tt#286

NO_TEST=third-party dependency
NO_DOC=third-party dependency
@psergee psergee force-pushed the psergee/no-gh-add-tt-dependency branch from c7c94f7 to 24cf626 Compare March 24, 2023 14:03
@Totktonada Totktonada added the full-ci Enables all tests for a pull request label Mar 24, 2023
ylobankov
ylobankov approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@ylobankov ylobankov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Totktonada Totktonada merged commit 10f7109 into master Mar 24, 2023
@Totktonada Totktonada deleted the psergee/no-gh-add-tt-dependency branch March 24, 2023 22:34
@Totktonada
Copy link
Member

Pushed to master as 3.0.0-entrypoint-106-g10f7109c7, cherry-picked to 2.11 as 2.11.0-rc1-83-g224b3032b (will appear in 2.11.1, not 2.11.0, which lives in the release/2.11.0 branch).

@ochaplashkin ochaplashkin mentioned this pull request Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Totktonada Totktonada Totktonada approved these changes

@ylobankov ylobankov ylobankov approved these changes

@LeonidVas LeonidVas LeonidVas approved these changes

Assignees
No one assigned
Labels
full-ci Enables all tests for a pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@psergee @coveralls @Totktonada @ylobankov @LeonidVas