-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate tarantoolctl from the tarantool repository #401
Merged
ylobankov
merged 2 commits into
tarantool:master
from
ochaplashkin:add-static-build-support
Jul 28, 2023
Merged
Migrate tarantoolctl from the tarantool repository #401
ylobankov
merged 2 commits into
tarantool:master
from
ochaplashkin:add-static-build-support
Jul 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totktonada
reviewed
Jul 19, 2023
Totktonada
reviewed
Jul 19, 2023
Totktonada
reviewed
Jul 19, 2023
Totktonada
reviewed
Jul 19, 2023
ochaplashkin
changed the title
Add static build support
Migrate tarantoolctl from the tarantool repository
Jul 26, 2023
Now test-run can run tests against Tarantool binary that can be located anywhere. Add an additional argument `--executable` [string] for test-run. This parameter sets a fixed path to the executable file. Warning: test library binaries are required to run tests anyway. Example usage: $ ./test-run.py --executable /foo/bar/tarantool In scope of #400
ylobankov
approved these changes
Jul 28, 2023
Totktonada
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glanced briefly, I see nothing critical.
find_exe()
definitely needs rewriting, it is hard to understand. OK to do it separately, maybe in #249.
In the near future we plan to test Tarantool installed from a DEB/RPM package. Since 3.0.0-alpha1 release [1] Tarantool packages don't have the tarantoolctl utility inside [2][3]. So tarantoolctl was added to the root directory of the project. Now test-run will always use the local tarantoolctl. [1] https://github.com/tarantool/tarantool/releases/tag/3.0.0-alpha1 [2] tarantool/tarantool#8771 [3] tarantool/tarantool#8866 Close #400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem?
In the near future we plan to test Tarantool installed from a DEB/RPM package. Since 3.0.0-alpha1 release 1 Tarantool packages don't have the tarantoolctl utility inside 23.
What's the solution?
It is necessary to "save" the tarantoolctl utility in order to use it regardless of whether it is part of future Tarantool packages or not. This can be done by simply copying the file to the root of the project directory.
How it was tested
Debian 11
Fedora 36
Close #400
Footnotes
https://github.com/tarantool/tarantool/releases/tag/3.0.0-alpha1 ↩
https://github.com/tarantool/tarantool/pull/8771 ↩
https://github.com/tarantool/tarantool/pull/8866 ↩