[2.10] Fix flaky test app-luatest/gh_6128_background_mode_test.lua (again) #8834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ligurio
force-pushed
the
ligurio/gh-6128-fix-flaky-test-2
branch
from
5525390
to
631258e
Compare
|
LOL, I suggest to use Mike Pall style for this: |
ligurio
force-pushed
the
ligurio/gh-6128-fix-flaky-test-2
branch
from
631258e
to
2f9ea7f
Compare
ligurio
changed the title
Previous attempt to fix flakiness in commit 6a2c73f ("test: fix flakiness in gh_6128_background_mode_test") used a constant buffer size in check_err_msg function. Tarantool 2.10 has a bit bigger log before a desired message that other versions of Tarantool and it leads to a this resulted in a truncated message ("entering the even" instead of "entering the event loop"). Patch replaces check_err_msg() implementation to grep_log used in luatest, it reads the whole log. Also patch renames check_err_msg to check_msg, because "entering the event loop" is not an error message. Follows up tarantool#6128 NO_CHANGELOG=fix test NO_DOC=fix test
ligurio
force-pushed
the
ligurio/gh-6128-fix-flaky-test-2
branch
from
2f9ea7f
to
24694eb
Compare
ligurio
changed the title
|
Resolved in scope of #8836. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous attempt to fix flakiness in commit 6a2c73f ("test: fix flakiness in gh_6128_background_mode_test") used a constant buffer size in check_err_msg function. Tarantool 2.10 has a bit bigger log before a desired message that other versions of Tarantool and it leads to a this resulted in a truncated message ("entering the even" instead of "entering the event loop"). Patch replaces check_err_msg() implementation to grep_log used in luatest, it reads the whole log.
Also patch renames check_err_msg to check_msg, because "entering the event loop" is not an error message.
Follows up #6128
NO_CHANGELOG=fix test
NO_DOC=fix test