[master] test: fix flakiness in gh_6128_background_mode_test (again) #8836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ligurio
changed the title
Previous attempt to fix flakiness in commit 6a2c73f ("test: fix flakiness in gh_6128_background_mode_test") used a constant buffer size in check_err_msg function. Tarantool 2.10 has a bit bigger log before a desired message that other versions of Tarantool and it leads to a this resulted in a truncated message ("entering the even" instead of "entering the event loop"). Patch replaces check_err_msg() implementation to grep_log used in luatest, it reads the whole log. Also patch renames check_err_msg to check_msg, because "entering the event loop" is not an error message. Follows up tarantool#6128 NO_CHANGELOG=fix test NO_DOC=fix test
ligurio
force-pushed
the
ligurio/gh-6128-fix-flaky-test-2-master
branch
from
8e37a58
to
4601403
Compare
ligurio
changed the title
ylobankov
approved these changes
Jul 3, 2023
Lord-KA
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Thanks for the patch! We've discussed in dm, that luatest.Server can't be used instead of popen, as it automatically initializes box.cfg{}, while for the test purposes it should be done from the shell (with -e). Besides that, as the dummy server in check_msg is not started, we don't need to kill it, thus it is ok too. Overall, LGTM.
Nit: maybe comment on the issues above in the code.
ligurio
added a commit
to tarantool/luatest
that referenced
this pull request
Jul 4, 2023
Function grep_log() could be useful for searching string patterns even
when Server instance is not possible. For example a case [1] when we
need to start Tarantool instance with our own options.
Now for using grep_log one needs create an empty Server instance and
then call grep_log() for it. It looks ugly:
```lua
local server = t.Server:new({})
local res = server:grep_log(msg, 1024, {filename = file})
```
Patch moves grep_log() to utils, this allows using grep_log() even
Server instance is not used.
1. tarantool/tarantool#8836
3 tasks
ligurio
added a commit
to tarantool/luatest
that referenced
this pull request
Jul 4, 2023
Function grep_log() could be useful for searching string patterns even
when Server instance is not possible. For example a case [1] when we
need to start Tarantool instance with our own options.
Now for using grep_log one needs create an empty Server instance and
then call grep_log() for it. It looks ugly:
```lua
local server = t.Server:new({})
local res = server:grep_log(msg, 1024, {filename = file})
```
Patch moves grep_log() to utils, this allows using grep_log() even
Server instance is not used.
1. tarantool/tarantool#8836
Follows up tarantool/tarantool#6128
ligurio
added a commit
to tarantool/luatest
that referenced
this pull request
Jul 4, 2023
Function grep_log() could be useful for searching string patterns even
when Server instance is not possible. For example a case [1] when we
need to start Tarantool instance with our own options.
Now for using grep_log one needs create an empty Server instance and
then call grep_log() for it. It looks ugly:
```lua
local server = t.Server:new({})
local res = server:grep_log(msg, 1024, {filename = file})
```
Patch moves grep_log() to utils, this allows using grep_log() even
Server instance is not used.
1. tarantool/tarantool#8836
Follows up tarantool/tarantool#6128
ligurio
added a commit
to tarantool/luatest
that referenced
this pull request
Jul 4, 2023
Function grep_log() could be useful for searching string patterns even
when Server instance is not possible. For example a case [1] when we
need to start Tarantool instance with our own options.
Now for using grep_log one needs create an empty Server instance and
then call grep_log() for it. It looks ugly:
```lua
local server = t.Server:new({})
local res = server:grep_log(msg, 1024, {filename = file})
```
Patch moves grep_log() to utils, this allows using grep_log() even
Server instance is not used.
1. tarantool/tarantool#8836
Follows up tarantool/tarantool#6128
ligurio
added a commit
to tarantool/luatest
that referenced
this pull request
Jul 4, 2023
Function grep_log() could be useful for searching string patterns even
when Server instance is not possible. For example a case [1] when we
need to start Tarantool instance with our own options.
Now for using grep_log one needs create an empty Server instance and
then call grep_log() for it. It looks ugly:
```lua
local server = t.Server:new({})
local res = server:grep_log(msg, 1024, {filename = file})
```
Patch moves grep_log() to utils, this allows using grep_log() even
Server instance is not used.
1. tarantool/tarantool#8836
Follows up tarantool/tarantool#6128
ligurio
added a commit
to tarantool/luatest
that referenced
this pull request
Jul 4, 2023
Function grep_log() could be useful for searching string patterns even
when Server instance is not possible. For example a case [1] when we
need to start Tarantool instance with our own options.
Now for using grep_log one needs create an empty Server instance and
then call grep_log() for it. It looks ugly:
```lua
local server = t.Server:new({})
local res = server:grep_log(msg, 1024, {filename = file})
```
Patch moves grep_log() to utils, this allows using grep_log() even
Server instance is not used.
1. tarantool/tarantool#8836
Follows up tarantool/tarantool#6128
ligurio
added a commit
to tarantool/luatest
that referenced
this pull request
Aug 14, 2023
Function grep_log() could be useful for searching string patterns even
when Server instance is not possible. For example a case [1] when we
need to start Tarantool instance with our own options.
Now for using grep_log one needs create an empty Server instance and
then call grep_log() for it. It looks ugly:
```lua
local server = t.Server:new({})
local res = server:grep_log(msg, 1024, {filename = file})
```
Patch moves grep_log() to utils, this allows using grep_log() even
Server instance is not used.
1. tarantool/tarantool#8836
Follows up tarantool/tarantool#6128
ligurio
added a commit
to tarantool/luatest
that referenced
this pull request
Aug 14, 2023
Function grep_log() could be useful for searching string patterns even
when Server instance is not possible. For example a case [1] when we
need to start Tarantool instance with our own options.
Now for using grep_log one needs create an empty Server instance and
then call grep_log() for it. It looks ugly:
```lua
local server = t.Server:new({})
local res = server:grep_log(msg, 1024, {filename = file})
```
Patch moves grep_log() to utils, this allows using grep_log() even
Server instance is not used.
1. tarantool/tarantool#8836
Follows up tarantool/tarantool#6128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: PR 2.10 - #8834
Previous attempt to fix flakiness in commit 6a2c73f ("test: fix flakiness in gh_6128_background_mode_test") used a constant buffer size in check_err_msg function. Tarantool 2.10 has a bit bigger log before a desired message that other versions of Tarantool and it leads to a this resulted in a truncated message ("entering the even" instead of "entering the event loop"). Patch replaces check_err_msg() implementation to grep_log used in luatest, it reads the whole log.
Also patch renames check_err_msg to check_msg, because "entering the event loop" is not an error message.
Follows up #6128
NO_CHANGELOG=fix test
NO_DOC=fix test