New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: move osx testing from per-commit to nightly #9571
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylobankov
force-pushed
the
ylobankov/move-osx-testing-to-nightly
branch
from
December 29, 2023 10:56
9edb646
to
cf247a2
Compare
It has been decided to move osx testing to the nightly basis due to lack of human and hardware resources to support per-commit testing. Part of tarantool/infra#187 NO_DOC=ci NO_TEST=ci NO_CHANGELOG=ci
ylobankov
force-pushed
the
ylobankov/move-osx-testing-to-nightly
branch
from
December 29, 2023 11:09
cf247a2
to
fa4cbea
Compare
ochaplashkin
approved these changes
Dec 29, 2023
Cherry picked to 3.0, 2.11, 2.10. |
ylobankov
added a commit
that referenced
this pull request
Feb 13, 2024
After we moved osx testing from the per-commit to nightly basis, we accidentally enabled running tarantool tests on macOS/M1 for 2.10 [1]. So we had some tests failed, and they were fixed by cherry-picking a few commits from the master branch [2]. Also, some tests were fixed by updating test-run to the new version [3] with needed fix [4]. So it's time to fix the last failed test (test/app/digest.test.lua) on macOS/M1 by disabling it due to the issue [5]. [1] #9571 [2] #9672 [3] #9685 [4] tarantool/test-run#422 [5] #6097 NO_DOC=testing stuff NO_TEST=testing stuff NO_CHANGELOG=testing stuff
ylobankov
added a commit
that referenced
this pull request
Feb 13, 2024
After we moved osx testing from the per-commit to nightly basis [1], we accidentally enabled running tarantool tests on macOS/M1 for 2.10. So we had some tests failed, and they were fixed by cherry-picking a few commits from the master branch [2]. Also, some tests were fixed by updating test-run to the new version [3] with needed fix [4]. So it's time to fix the last failed test (test/app/digest.test.lua) on macOS/M1 by disabling it due to the issue [5]. [1] #9571 [2] #9672 [3] #9685 [4] tarantool/test-run#422 [5] #6097 NO_DOC=testing stuff NO_TEST=testing stuff NO_CHANGELOG=testing stuff
ylobankov
added a commit
that referenced
this pull request
Feb 13, 2024
After we moved osx testing from the per-commit to nightly basis [1], we accidentally enabled running tarantool tests on macOS/M1 for 2.10. So we had some tests failed, and they were fixed by cherry-picking a few commits from the master branch [2]. Also, some tests were fixed by updating test-run to the new version [3] with needed fix [4]. So it's time to fix the last failed test (test/app/digest.test.lua) on macOS/M1 by disabling it due to the issue [5]. [1] #9571 [2] #9672 [3] #9685 [4] tarantool/test-run#422 [5] #6097 NO_DOC=testing stuff NO_TEST=testing stuff NO_CHANGELOG=testing stuff
ylobankov
added a commit
that referenced
this pull request
Feb 13, 2024
After we moved osx testing from the per-commit to nightly basis [1], we accidentally enabled running tarantool tests on macOS/M1 for 2.10. So we had some tests failed, and they were fixed by cherry-picking a few commits from the master branch [2]. Also, some tests were fixed by updating test-run to the new version [3] with needed fix [4]. So it's time to fix the last failed test (test/app/digest.test.lua) on macOS/M1 by disabling JIT in it due to the issue [5]. [1] #9571 [2] #9672 [3] #9685 [4] tarantool/test-run#422 [5] #6097 NO_DOC=testing stuff NO_TEST=testing stuff NO_CHANGELOG=testing stuff
ylobankov
added a commit
that referenced
this pull request
Feb 14, 2024
After we moved osx testing from the per-commit to nightly basis [1], we accidentally enabled running tarantool tests on macOS/M1 for 2.10. So we had some tests failed, and they were fixed by cherry-picking a few commits from the master branch [2]. Also, some tests were fixed by updating test-run to the new version [3] with needed fix [4]. So it's time to fix the last failed test (test/app/digest.test.lua) on macOS/M1 by disabling JIT in it due to the issue [5]. [1] #9571 [2] #9672 [3] #9685 [4] tarantool/test-run#422 [5] #6097 NO_DOC=testing stuff NO_TEST=testing stuff NO_CHANGELOG=testing stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been decided to move osx testing to the nightly basis due to lack
of human and hardware resources to support per-commit testing.
Part of https://github.com/tarantool/infra/issues/187