Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.10] test: disable JIT in test/app/digest.test.lua #9686

Merged
merged 1 commit into from Feb 14, 2024

Conversation

ylobankov
Copy link
Member

@ylobankov ylobankov commented Feb 13, 2024

After we moved osx testing from the per-commit to nightly basis [1], we accidentally enabled running tarantool tests on macOS/M1 for 2.10. So we had some tests failed, and they were fixed by cherry-picking a few commits from the master branch [2]. Also, some tests were fixed by updating test-run to the new version [3] with needed fix [4]. So it's time to fix the last failed test (test/app/digest.test.lua) on macOS/M1 by disabling JIT in it due to the issue [5].

[1] #9571
[2] #9672
[3] #9685
[4] tarantool/test-run#422
[5] #6097


Tested on macOS/M1 as well:

...
Top 10 longest tests (seconds):
*  63.54 replication-luatest/quorum_orphan_test.lua
*  57.07 sql-tap/in2.test.lua:memtx
*  30.97 replication-luatest/gh_4669_applier_reconnect_test.lua
*  22.82 replication-luatest/quorum_misc_test.lua
*  22.43 sql-tap/trigger8.test.lua:memtx
*  20.72 box/gh-5422-broken_snapshot.test.lua
*  19.87 replication-luatest/gh_7318_box_wait_limbo_acked_test.lua
*  17.62 sql-tap/trigger8.test.lua:vinyl
*  15.89 engine-luatest/gh_6436_field_foreign_key_test.lua
*  15.05 vinyl/gh-4810-dump-during-index-build.test.lua
---------------------------------------------------------------------------------
Statistics:
* disabled: 73
* pass: 1583
* skip: 6

@ylobankov ylobankov requested a review from a team as a code owner February 13, 2024 21:51
@ylobankov ylobankov force-pushed the ylobankov/disable-digest.test.lua-test branch from 4812185 to 2a6847e Compare February 13, 2024 21:56
After we moved osx testing from the per-commit to nightly basis [1],
we accidentally enabled running tarantool tests on macOS/M1 for 2.10.
So we had some tests failed, and they were fixed by cherry-picking a
few commits from the master branch [2]. Also, some tests were fixed by
updating test-run to the new version [3] with needed fix [4]. So it's
time to fix the last failed test (test/app/digest.test.lua) on macOS/M1
by disabling JIT in it due to the issue [5].

[1] #9571
[2] #9672
[3] #9685
[4] tarantool/test-run#422
[5] #6097

NO_DOC=testing stuff
NO_TEST=testing stuff
NO_CHANGELOG=testing stuff
@ylobankov ylobankov force-pushed the ylobankov/disable-digest.test.lua-test branch from 2a6847e to 34feeb3 Compare February 13, 2024 22:18
@ylobankov ylobankov changed the title [2.10] test: disable test/app/digest.test.lua on macOS/M1 [2.10] test: disable JIT in test/app/digest.test.lua Feb 13, 2024
@coveralls
Copy link

Coverage Status

coverage: 85.127% (+0.02%) from 85.109%
when pulling 34feeb3 on ylobankov/disable-digest.test.lua-test
into 71d5ff0
on release/2.10
.

Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've no objections. But the issue is Igor's one, it is better to ask him.

Copy link
Contributor

@ochaplashkin ochaplashkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@igormunkin igormunkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ylobankov, thanks for the patch! LGTM as trivial.

@ylobankov ylobankov merged commit 7d6f39e into release/2.10 Feb 14, 2024
60 checks passed
@ylobankov ylobankov deleted the ylobankov/disable-digest.test.lua-test branch February 14, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants