New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.10] test: disable JIT in test/app/digest.test.lua #9686
[2.10] test: disable JIT in test/app/digest.test.lua #9686
Conversation
4812185
to
2a6847e
Compare
After we moved osx testing from the per-commit to nightly basis [1], we accidentally enabled running tarantool tests on macOS/M1 for 2.10. So we had some tests failed, and they were fixed by cherry-picking a few commits from the master branch [2]. Also, some tests were fixed by updating test-run to the new version [3] with needed fix [4]. So it's time to fix the last failed test (test/app/digest.test.lua) on macOS/M1 by disabling JIT in it due to the issue [5]. [1] #9571 [2] #9672 [3] #9685 [4] tarantool/test-run#422 [5] #6097 NO_DOC=testing stuff NO_TEST=testing stuff NO_CHANGELOG=testing stuff
2a6847e
to
34feeb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've no objections. But the issue is Igor's one, it is better to ask him.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ylobankov, thanks for the patch! LGTM as trivial.
After we moved osx testing from the per-commit to nightly basis [1], we accidentally enabled running tarantool tests on macOS/M1 for 2.10. So we had some tests failed, and they were fixed by cherry-picking a few commits from the master branch [2]. Also, some tests were fixed by updating test-run to the new version [3] with needed fix [4]. So it's time to fix the last failed test (test/app/digest.test.lua) on macOS/M1 by disabling JIT in it due to the issue [5].
[1] #9571
[2] #9672
[3] #9685
[4] tarantool/test-run#422
[5] #6097
Tested on macOS/M1 as well: