Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TARDIS PEP8 complaint #2041

Open
epassaro opened this issue Jun 2, 2022 · 3 comments
Open

Make TARDIS PEP8 complaint #2041

epassaro opened this issue Jun 2, 2022 · 3 comments

Comments

@epassaro
Copy link
Member

epassaro commented Jun 2, 2022

Currently, TARDISis not PEP8 complaint.

To check this, install flake8 and run flake8 tardis.

To achieve this we need to:

  • Configure Flake8 through configuration files.
  • Ensure that Flake8 and Black play nicely together
  • Select appropriate Flake8 plugins, such as pep8-naming (discuss)
  • Make necessary changes to TARDIS code
  • more?

The CI pipeline is ready to check PEP8, just requires removing the if: false from the flake8 job.

@saiashishanshuman
Copy link

Hey @epassaro, Sai here. So I am a beginner level python user and very new to Open Source. I was hoping to make my contribution to TARDIS and this issue would be a good start for it. Would you please assign this to me and I would try my best to contribute.

@prady0t
Copy link

prady0t commented May 15, 2023

Hey can I work on this issue ?

@wkerzendorf
Copy link
Member

As this issue makes a large number of changes in the code - this is not a good issue for beginners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants