Pass on headers from original request. #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smancke
approved these changes
Dec 8, 2016
| @@ -99,7 +99,9 @@ func (tcs *CacheStrategy) HashWithParameters(method string, url string, requestH | |||
| } | |||
| } | |||
|
|
|||
| return hex.EncodeToString(hasher.Sum(nil)) | |||
| hash := hex.EncodeToString(hasher.Sum(nil)) | |||
| // logging.Logger.Error("HASH = " + hash + ", url = " + url + ", host = " + requestHeader.Get("Host")) | |||
| // Jira 3946: go deletes the "Host" header from the request (for whatever reasons): | ||
| // https://golang.org/src/net/http/request.go: | ||
| // 123 // For incoming requests, the Host header is promoted to the | ||
| // 124 // Request.Host field and removed from the Header map. |
There was a problem hiding this comment.
that's just the copy&pasted line numbers from request.go
… incompatibilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Host header, which is automatically deleted by go, is restored and, together with the other headers from the original request, is passed on to the FetchDefinitions.
That way we can make caching decisions based on the host, for services that handle more than one host, with same paths but different content.