Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extracted logging to seperate repo, now we should use it #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Extracted logging to seperate repo, now we should use it #56

wants to merge 1 commit into from

Conversation

domano
Copy link
Contributor

@domano domano commented Jul 10, 2017

WARNING: WILL BREAK BUILDS DEPENDENT ON THE OLD LOGGING PACKAGE.

@domano domano requested a review from smancke July 10, 2017 16:26
@domano
Copy link
Contributor Author

domano commented Jul 10, 2017

I opened this PR but we should not merge it before changing the existing projects dependent on the logging package

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 94.107% when pulling e2102e0 on refactor/use-extracted-logging-lib into f05f8e2 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smancke smancke Awaiting requested review from smancke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domano @coveralls