Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

feat: Comment on issues and PRs with release information #76

Closed
kamranayub opened this issue May 28, 2020 · 2 comments · Fixed by #96
Closed

feat: Comment on issues and PRs with release information #76

kamranayub opened this issue May 28, 2020 · 2 comments · Fixed by #96
Assignees
Labels
🔍 needs triage ✨ feat New feature or request

Comments

@kamranayub
Copy link

Is your feature request related to a problem? Please describe.

It's common to ask, "What version was this issue or PR fixed in?"

Describe the solution you'd like

Semantic Release does this via the https://github.com/semantic-release/github plug-in

It adds a comment and labels issues and PRs that are included in the release.

Describe alternatives you've considered

n/a

Additional context

Here's what it looks like:

semantic-release/github#269

image

@therynamo
Copy link
Contributor

Awesome suggestion @kamranayub! I would love to get this up and running.

A few questions:

Would you expect the "npm package" to be added to the comment like in the above screenshot? For instance if a mono-repo were to publish, would we need the package version of that publish to be reported back to the PR of each package published in that release?

@AndersDJohnson
Copy link
Contributor

@kamranayub This is a cool feature proposal!

Just wanted to show an existing approach that's supported natively in GitHub already, in case it helps in the interim until this feature is available.

If you go the commit URL for the merge commit on a PR, e.g., https://github.com/my-org/my-repo/commit/abc123, you can see all the tags in which it's included, which might correspond to a release:

Screen Shot 2020-06-01 at 3 06 17 PM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔍 needs triage ✨ feat New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants