Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notification: (slack) reply in thread for alert escalations #1566

Merged
merged 10 commits into from
May 19, 2021

Conversation

arurao
Copy link
Contributor

@arurao arurao commented May 19, 2021

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR sends a slack notification in a thread for any alert escalations, instead of always sending a new slack message for escalations.

Screenshots:
Screen Shot 2021-05-19 at 12 04 02 PM

Screen Shot 2021-05-19 at 12 04 11 PM

@mastercactapus
Copy link
Member

Since the original message already contains the alert info, and could be updated in the future, maybe we can change text to just be something like "Escalated."?

@arurao arurao marked this pull request as draft May 19, 2021 15:49
@arurao arurao marked this pull request as ready for review May 19, 2021 16:16
notification/slack/channel.go Outdated Show resolved Hide resolved
Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
dctalbot
dctalbot previously approved these changes May 19, 2021
dctalbot
dctalbot previously approved these changes May 19, 2021
mastercactapus
mastercactapus previously approved these changes May 19, 2021
@arurao arurao dismissed stale reviews from mastercactapus and dctalbot via 5af0cae May 19, 2021 20:34
@arurao arurao merged commit c3f5fb4 into master May 19, 2021
@arurao arurao deleted the slack-thread-replies branch May 19, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants