Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/details: prevent rendering 0 #1652

Merged
merged 1 commit into from
Jun 23, 2021
Merged

ui/details: prevent rendering 0 #1652

merged 1 commit into from
Jun 23, 2021

Conversation

dctalbot
Copy link
Contributor

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR fixes an issue in which we render the string "0" when there are no quick links e.g. rotation details

Additional Info:
JSX rules: https://reactjs.org/docs/jsx-in-depth.html#booleans-null-and-undefined-are-ignored

@dctalbot dctalbot merged commit 5291150 into master Jun 23, 2021
@dctalbot dctalbot deleted the fix-details branch June 23, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants