Skip to content

Commit

Permalink
src: only open HandleScope when necessary
Browse files Browse the repository at this point in the history
PR-URL: nodejs#26734
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
  • Loading branch information
addaleax authored and targos committed Mar 27, 2019
1 parent ae0acbf commit 12c51ba
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/api/callback.cc
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ InternalCallbackScope::~InternalCallbackScope() {
void InternalCallbackScope::Close() {
if (closed_) return;
closed_ = true;
HandleScope handle_scope(env_->isolate());

if (!env_->can_call_into_js()) return;
if (failed_ && !env_->is_main_thread() && env_->is_stopping()) {
Expand Down Expand Up @@ -117,6 +116,7 @@ void InternalCallbackScope::Close() {
return;
}

HandleScope handle_scope(env_->isolate());
Local<Object> process = env_->process_object();

if (!env_->can_call_into_js()) return;
Expand Down

0 comments on commit 12c51ba

Please sign in to comment.