fix(walletd): emit AccountChanged event on changes for account refresh #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
approved these changes
Mar 6, 2024
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Mar 6, 2024
* development: fix(walletd): emit AccountChanged event on changes for account refresh (tari-project#956)
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Mar 8, 2024
* development: feat: change bindings package usage to git instead of local (tari-project#963) v0.4.1 fix(engine): claiming burns/fees call frame error (tari-project#960) ci: fix windows and macos builds (tari-project#961) v0.4.0 ci: add tari generate to built binaries (tari-project#959) refactor(engine)!: substate address based on entity id prefix (tari-project#951) fix(walletd): emit AccountChanged event on changes for account refresh (tari-project#956)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Emit missing event if the account is updated via refresh.
Motivation and Context
The account monitor only emitted the AccountChanged event after a successful transaction involving the account is detected. However, if a client (e.g. cucumber) is polling the account refresh, the refresh can detect changes to the account before the transaction is detected as complete. This is the typical case as the cucumber polls faster than the wallet polls the indexer for a transaction result.
This bug led to
Claim and transfer confidential assets via wallet daemonnever finishing because once the finalised transaction comes through, there are no changes detected because the refresh already updated the account.How Has This Been Tested?
Claim and transfer confidential assets via wallet daemoncucumber completes.What process can a PR reviewer use to test or verify this change?
CI
Breaking Changes