fix(engine): claiming burns/fees call frame error #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
engine-fix-call-stack-error
branch
from
3cf65e7
to
944f663
Compare
stringhandler
approved these changes
Mar 7, 2024
Merged
via the queue into
tari-project:development
with commit Mar 7, 2024
c6a114f
9 of 10 checks passed
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Mar 8, 2024
* development: feat: change bindings package usage to git instead of local (tari-project#963) v0.4.1 fix(engine): claiming burns/fees call frame error (tari-project#960) ci: fix windows and macos builds (tari-project#961) v0.4.0 ci: add tari generate to built binaries (tari-project#959) refactor(engine)!: substate address based on entity id prefix (tari-project#951) fix(walletd): emit AccountChanged event on changes for account refresh (tari-project#956)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix(engine): claiming burns/fees call frame error
Motivation and Context
Id provider needs a call stack to get the correct entity ID, however creating bucket ids do not require an entity id. Claiming burns and fees do not have a call frame since they are native instructions, and so would error when getting the id provider.
This PR allocates a bucket id without requiring an active call frame.
How Has This Been Tested?
Claim burn cucumber passes
What process can a PR reviewer use to test or verify this change?
Claim burn/fee
Breaking Changes