feat: change bindings package usage to git instead of local #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
approved these changes
Mar 8, 2024
stringhandler
merged commit a5fc0ed
into
tari-project:development
10 of 11 checks passed
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Mar 8, 2024
* development: feat: change bindings package usage to git instead of local (tari-project#963) v0.4.1 fix(engine): claiming burns/fees call frame error (tari-project#960) ci: fix windows and macos builds (tari-project#961) v0.4.0 ci: add tari generate to built binaries (tari-project#959) refactor(engine)!: substate address based on entity id prefix (tari-project#951) fix(walletd): emit AccountChanged event on changes for account refresh (tari-project#956)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the package from local reference to git reference, this is useful for further referencing of the
wallet_daemon_clientpackage.Motivation and Context
I have prepared couple changes so in the end we can add the template-web to the dan-testing without relying on package on local paths.
How Has This Been Tested?
I have running template web with no package being locally referenced in the package.json.
What process can a PR reviewer use to test or verify this change?
For now you can only try to compile the
wallet_daemon_clientto see that it's working.Breaking Changes