Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement tari_crypto hashing API: Comms #4393

Closed
hansieodendaal opened this issue Aug 5, 2022 · 2 comments
Closed

Implement tari_crypto hashing API: Comms #4393

hansieodendaal opened this issue Aug 5, 2022 · 2 comments
Assignees
@jorgeantonio21
Labels
A-security Area - Security related

Comments

@hansieodendaal
Copy link
Contributor

Effective GitHub hash: d25d726
# Reference Function/Area Yes/No URL URL long
24 comms/core/src/peer_manager/identity_signature.rs:141 fn construct_challenge Yes identity_signature.rs:141 https://github.com/tari-project/tari/blob/development/comms/core/src/peer_manager/identity_signature.rs#L141
25 comms/core/src/peer_manager/node_id.rs:74 NodeId::from_key Yes node_id.rs:74 https://github.com/tari-project/tari/blob/development/comms/core/src/peer_manager/node_id.rs#L74
26 comms/dht/src/dedup/mod.rs:51 pub fn create_message_hash( Yes mod.rs:51 https://github.com/tari-project/tari/blob/development/comms/dht/src/dedup/mod.rs#L51
@jorgeantonio21 jorgeantonio21 self-assigned this Aug 9, 2022
@jorgeantonio21 jorgeantonio21 mentioned this issue Aug 10, 2022
Merged
@sdbondi sdbondi mentioned this issue Aug 10, 2022
Merged
@sdbondi
Copy link
Member

sdbondi commented Aug 10, 2022

Implemented one that was missing here in #4432

stringhandler pushed a commit that referenced this issue Aug 10, 2022
@jorgeantonio21
fix: add hashing api on comms repo (see issue #4393) (#4429)
9f32c31 
Description
--- Add use of hashing API on repo `comms`.

Motivation and Context
--- Tackle issue #4393

How Has This Been Tested?
--- Unit tests
stringhandler pushed a commit that referenced this issue Aug 10, 2022
@sdbondi
fix(comms)!: use domain hasher for noise DH key derivation (#4432)
c93182c 
Description
---
Hashes the noise DH shared secret  

Motivation and Context
---
All DH shared secrets should be hashed to remove any possible slight bias in the resulting key.

Ref #4393 

How Has This Been Tested?
---
Unit test updated. Existing tests pass
@hansieodendaal hansieodendaal added the A-security Area - Security related label Aug 15, 2022
@jorgeantonio21
Copy link
Contributor

I think this issue can be closed as of now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgeantonio21 jorgeantonio21

Labels
A-security Area - Security related
Projects
Tari Esme Testnet
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sdbondi @jorgeantonio21 @hansieodendaal