Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tari_crypto hashing API: base_layer core #4394

Closed
hansieodendaal opened this issue Aug 5, 2022 · 0 comments · Fixed by #4447
Closed

Implement tari_crypto hashing API: base_layer core #4394

hansieodendaal opened this issue Aug 5, 2022 · 0 comments · Fixed by #4447
Assignees
Labels
A-security Area - Security related

Comments

@hansieodendaal
Copy link
Contributor

Effective GitHub hash: d25d726
# Reference Function/Area Yes/No URL URL long
1 base_layer/common_types/src/types/bullet_rangeproofs.rs:42 Hashable for BulletRangeProof Yes bullet_rangeproofs.rs:42 https://github.com/tari-project/tari/blob/development/base_layer/common_types/src/types/bullet_rangeproofs.rs#L42
4 base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs:2732 UniqueIdIndexKey::new Yes lmdb_db.rs:2732 https://github.com/tari-project/tari/blob/development/base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs#L2732
5 base_layer/core/src/covenants/fields.rs:370 pub fn construct_challenge_from( Yes fields.rs:370 https://github.com/tari-project/tari/blob/development/base_layer/core/src/covenants/fields.rs#L370
6 base_layer/core/src/mempool/unconfirmed_pool/unconfirmed_pool.rs:653 fn get_output_token_id( Yes unconfirmed_pool.rs:653 https://github.com/tari-project/tari/blob/development/base_layer/core/src/mempool/unconfirmed_pool/unconfirmed_pool.rs#L653
7 base_layer/core/src/transactions/transaction_components/encrypted_value.rs:121 fn kdf_aead( Yes encrypted_value.rs:121 https://github.com/tari-project/tari/blob/development/base_layer/core/src/transactions/transaction_components/encrypted_value.rs#L121
10 base_layer/core/src/transactions/transaction_components/side_chain/contract_acceptance_challenge.rs:32 ContractAcceptanceChallenge::new Yes contract_acceptance_challenge.rs:32 https://github.com/tari-project/tari/blob/development/base_layer/core/src/transactions/transaction_components/side_chain/contract_acceptance_challenge.rs#L32
12 base_layer/core/src/transactions/transaction_components/side_chain/contract_update_proposal_acceptance_challenge.rs:34 ContractUpdateProposalAcceptanceChallenge::new Yes contract_update_proposal_acceptance_challenge.rs:34 https://github.com/tari-project/tari/blob/development/base_layer/core/src/transactions/transaction_components/side_chain/contract_update_proposal_acceptance_challenge.rs#L34
13 base_layer/core/src/transactions/transaction_components/side_chain/signer_signature.rs:67 fn build_final_challenge Yes signer_signature.rs:67 https://github.com/tari-project/tari/blob/development/base_layer/core/src/transactions/transaction_components/side_chain/signer_signature.rs#L67
17 base_layer/core/src/transactions/transaction_protocol/sender.rs:704 pub fn calculate_tx_id Yes sender.rs:704 https://github.com/tari-project/tari/blob/development/base_layer/core/src/transactions/transaction_protocol/sender.rs#L704
@jorgeantonio21 jorgeantonio21 self-assigned this Aug 10, 2022
@hansieodendaal hansieodendaal added the A-security Area - Security related label Aug 15, 2022
stringhandler pushed a commit that referenced this issue Aug 19, 2022
Description
--- 
Refactor base_layer repo to use the hashing API.

Motivation and Context
--- 
Fixes #4394.

How Has This Been Tested?
--- 
Unit tests
sdbondi added a commit to sdbondi/tari that referenced this issue Aug 22, 2022
* development:
  feat!: add hashing API use to base layer (see issue tari-project#4394) (tari-project#4447)
  feat(wallet): adds --stealth-one-sided flag to make-it-rain (tari-project#4508)
  fix!: change monero consensus encoding an update for hardfork v15 (tari-project#4492)
  fix(core/covenants)!: update covenants to support OutputType enum (tari-project#4472)
  feat(core)!: restrict output types to only those permitted by consensus (tari-project#4467)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-security Area - Security related
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants