Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: chat ffi find by message #6354

Merged

Conversation

brianp
Copy link
Contributor

@brianp brianp commented May 25, 2024

Description

Add functionality for a chat client to locate a message by id.

Motivation and Context

Making it simpler for clients to do things like reference an older message in history via reply.

How Has This Been Tested?

Cucumber only. It's kind of a weird integration test, but it made the most sense to test there.

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@brianp brianp requested a review from a team May 25, 2024 03:02
Copy link

github-actions bot commented May 25, 2024

Test Results (CI)

    3 files    120 suites   37m 59s ⏱️
1 275 tests 1 275 ✅ 0 💤 0 ❌
3 817 runs  3 817 ✅ 0 💤 0 ❌

Results for commit d70096b.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels May 25, 2024
Copy link

github-actions bot commented May 25, 2024

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   32m 46s ⏱️ + 32m 46s
34 tests +34  32 ✅ +32  0 💤 ±0  2 ❌ +2 
38 runs  +38  33 ✅ +33  0 💤 ±0  5 ❌ +5 

For more details on these failures, see this check.

Results for commit d70096b. ± Comparison against base commit bc2ac4c.

♻️ This comment has been updated with latest results.

@brianp brianp force-pushed the feat-chat-ffi-find-by-message-id branch from a15ee00 to d70096b Compare May 27, 2024 16:11
@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label May 27, 2024
@SWvheerden SWvheerden merged commit 28c7659 into tari-project:development May 28, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants