feat: chat ffi find by message #6354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 120 suites 37m 59s ⏱️ Results for commit d70096b. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files + 2 11 suites +11 32m 46s ⏱️ + 32m 46s For more details on these failures, see this check. Results for commit d70096b. ± Comparison against base commit bc2ac4c. ♻️ This comment has been updated with latest results. |
brianp
force-pushed
the
feat-chat-ffi-find-by-message-id
branch
from
a15ee00
to
d70096b
Compare
SWvheerden
approved these changes
May 27, 2024
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add functionality for a chat client to locate a message by id.
Motivation and Context
Making it simpler for clients to do things like reference an older message in history via reply.
How Has This Been Tested?
Cucumber only. It's kind of a weird integration test, but it made the most sense to test there.
Breaking Changes