Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Sqlite backend for Wallet #938

Closed
philipr-za opened this issue Oct 30, 2019 · 0 comments · Fixed by #1071
Closed

Implement Sqlite backend for Wallet #938

philipr-za opened this issue Oct 30, 2019 · 0 comments · Fixed by #1071
Assignees
Milestone

Comments

@philipr-za
Copy link
Contributor

No description provided.

@philipr-za philipr-za self-assigned this Oct 30, 2019
@philipr-za philipr-za added this to the TestNet Release milestone Oct 30, 2019
CjS77 added a commit that referenced this issue Nov 19, 2019
Merge pull request #1025

Add a Sqlite storage backed implementation for the Output Manager
Service and provide a test that tests both the in-memory and sqlite
backends using the same logic.

The backend is not included as part of the default Wallet build yet as
the In-Memory DB is more consistent for initial mobile app dev but can
be enabled with a single line change when we are ready.

Motivation and Context
Towards completing #938 Still need to implement the Sqlite backends for
the Transaction and Contacts service but those are significantly smaller
than the OMS
CjS77 added a commit that referenced this issue Nov 27, 2019
Merge pull request #1055

This PR adds a Sqlite based backend for the Transaction Service.

It also provides storage backend tests for both the existing MemoryDB
and Sqlite backends using the same code.

Also runs all the functional integration tests for the Transaction
service using both backends.

Motivation and Context
Towards #938

How Has This Been Tested?
Tests provided
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant