Implement Sqlite backends for Contacts service and Wallet peer db #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipr-za
force-pushed
the
philip-contacts-wallet-sqlite
branch
3 times, most recently
from
36d11f8
to
f02a5a0
Compare
This PR adds a Sqlite backend for the Contacts Service and the Peer database for the wallet It also update the respective integration tests to test using both the sqlite and memory db’s
philipr-za
force-pushed
the
philip-contacts-wallet-sqlite
branch
from
f02a5a0
to
4accd2a
Compare
CjS77
approved these changes
Nov 28, 2019
| is_read INTEGER NOT NULL DEFAULT 0, | ||
| FOREIGN KEY(dest_pub_key) REFERENCES contacts(pub_key) | ||
| ); | ||
| -- CREATE TABLE sent_messages ( |
There was a problem hiding this comment.
Shouldn't you just nuke these rather than comment them out, since you delete the diesel table definitions in schema.rs?
There was a problem hiding this comment.
schema.rs is generated from these migrations and these will come back in if we do text messaging so I thought best to leave them here for the future.
CjS77
added a commit
that referenced
this pull request
Nov 29, 2019
) Merge pull request #1071 This PR adds a Sqlite backend for the Contacts Service and the Peer database for the wallet It also update the respective integration tests to test using both the sqlite and memory db’s
CjS77
added a commit
that referenced
this pull request
Dec 2, 2019
) Merge pull request #1071 This PR adds a Sqlite backend for the Contacts Service and the Peer database for the wallet It also update the respective integration tests to test using both the sqlite and memory db’s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a Sqlite backend for the Contacts Service and the Peer database for the wallet
It also update the respective integration tests to test using both the sqlite and memory db’s
Motivation and Context
Closes #938
How Has This Been Tested?
test provided
Types of changes
Checklist:
developmentbranchcargo-fmt --allbefore pushing