Only store unique store and forward messages #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonknight64
force-pushed
the
yuko-saf_duplicate_message_insert
branch
from
06bf879
to
3896e6e
Compare
sdbondi
reviewed
May 17, 2020
neonknight64
force-pushed
the
yuko-saf_duplicate_message_insert
branch
from
3896e6e
to
8cf9b7c
Compare
sdbondi
reviewed
May 18, 2020
| ALTER TABLE stored_messages | ||
| ADD body_hash TEXT; | ||
|
|
||
| CREATE UNIQUE INDEX uidx_stored_messages_body_hash ON stored_messages (body_hash); |
There was a problem hiding this comment.
Tested migration and works well (nulls are not counted towards the unique index as expected)
There was a problem hiding this comment.
That is great!
- These changes allow only unique messages to be stored by the store and forward system. - This is achieved by comparing the body hash of a new message to the hashes of the currently stored set of messages. Only if the body content is unique is the message stored by the store and forward database. - Modified the store and forward database insert_message test to also test the behaviour when a duplicate message is inserted.
neonknight64
force-pushed
the
yuko-saf_duplicate_message_insert
branch
from
8cf9b7c
to
3c96423
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Limit unnecessary storage of messages with duplicate content.
How Has This Been Tested?
Modified the store and forward database insert_message test to also test the behaviour when a duplicate message is inserted.
Types of changes
Checklist:
developmentbranch.cargo-fmt --allbefore pushing.