Adding GetCalcTiming function to grpc service #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving header helper functions from cli The header height collection was tightly coupled to the parser, moving these to the BlockHeader seemed like the logical place for them these functions to live. They have been reused in the grpc service, these changes are the beginning of decoupling some of the functionality from the parser. Adding function comment Adding better logging and parameter comments Adding request argument validation fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added in the GetCalcTiming grpc endpoint. Part of doing that was decoupling some of the functionality from the
Parserthese were only small changes, as there is further work required there to fully de-couple the cli from the base node. The height lists and header responses were moved into theBlockHeader, there could be a better place for them, but it made sense in context.Motivation and Context
Getting more of the functionality ported to the GRPC interface is going to help with the block explorer requirements. This was some low hanging fruit to get started with.
How Has This Been Tested?
cargo testNo new tests have been written for the grpc endpoints yet.
Types of changes
Checklist:
developmentbranch.cargo-fmt --allbefore pushing.