Increased redundancy for SAF messages #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a message (with an explicit destination) is stored by a node, broadcast `n` messages to connected peers that are close to the destination to increase redundancy. As a message is propagated closer to the destination, the message will start to be stored for an offline peer once it reaches the neighbourhood of the destination. Because propagation is more targeted, it may miss some nodes that could be considered neighbours by the wallet. This PR increases the number of nodes that see the message as the message reaches the neighbourhood.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a message (with an explicit destination) is stored by a node,
broadcast
nmessages to connected peers that are close to thedestination to increase redundancy.
As a message is propagated closer to the destination, the message
will start to be stored for an offline peer once it reaches the
neighbourhood of the destination. Because propagation is more targeted,
it may miss some nodes that could be considered neighbours by the
wallet. This PR increases the number of nodes that see the message
as the message reaches the neighbourhood by broadcasting to a larger number
of connected peers close to the destination.
Motivation and Context
Increase SAF message redundancy in neighbourhood to increase SAF reliability
How Has This Been Tested?
memorynet
Types of changes
Checklist:
developmentbranch.cargo-fmt --allbefore pushing.