-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement daemon-mode in tari_base_node #2383
Merged
stringhandler
merged 3 commits into
tari-project:development
from
StriderDM:base_node_daemon_mode
Nov 2, 2020
Merged
Implement daemon-mode in tari_base_node #2383
stringhandler
merged 3 commits into
tari-project:development
from
StriderDM:base_node_daemon_mode
Nov 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
added a commit
to stringhandler/tari
that referenced
this pull request
Oct 26, 2020
…ri-project#2357) Revert change to fetch blocks utxos txos (tari-project#2357)
} else { | ||
println!("Node has been successfully configured and initialized in daemon mode. Starting CLI loop."); | ||
base_node_handle = rt.spawn(ctx.run()); | ||
cli_loop(None, shutdown); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just remove this call entirely?
Suggested change
cli_loop(None, shutdown); | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
6227960
to
5ae77be
Compare
Prob need a rebase, the clippy errors were fixed I think |
5ae77be
to
98d8009
Compare
stringhandler
added a commit
that referenced
this pull request
Nov 24, 2020
Major changes since v0.6.0 --- - [#2431](#2431) Database refactor to remove checkpoints and more efficient calculation of MMR roots - [#2352](#2352) Add DNS seed support in base node Minor changes since v0.6.0 --- - [#2448](#2448) Add OpenSSL to Windows install, runtime - [#2434](#2434) Add supervisord setup notes - [#2439](#2439) Provide initial sync status to merge mining proxy - [#2377](#2377) Message malleability detect and ban - [#2447](#2447) Fix for xmrig powershell script - [#2440](#2440) Stagenet Setup Guide Corrections - [#2444](#2444) DHT connectivity waits for comms connectivity before starting - [#2427](#2427) Update merge mining runtime, README, Win install - [#2420](#2420) Show base node chain tip and sync status in the console wallet - [#2419](#2419) Add optional fee_per_gram field to console wallet Send Tx form - [#2421](#2421) Fix QR code rendering in the console wallet - [#2423](#2423) Plumb in the balance in the console wallet - [#2415](#2415) Prevent loop in peer sync by storing all peers attempted - [#2383](#2383) Implement daemon-mode in tari_base_node - [#2407](#2407) Simplify automated stress test - [#2397](#2397) Fix preset config files - [#2400](#2400) Implement wallet base node service - [#2403](#2403) Add exclusive file locks to Wallet, Chain and Peer db’s - [#2408](#2408) Fix wallet conversion error for a valid tx status - [#2356](#2356) Combine validation code to use same function in pruned and archive mode. - [#2371](#2371) Add configurable BN service request timeouts - [#2430](#2430) Implement entry and persistence of custom base node in console wallet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a daemon mode for the Tari Base Node
Description
Starts application without CLI parser when --daemon-mode argument is present.
Motivation and Context
How Has This Been Tested?
cargo-test --all --all-features
Types of changes
Checklist:
development
branch.cargo-fmt --all
before pushing.cargo test
successfully before submitting my PR.