Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement daemon-mode in tari_base_node #2383

Merged

Conversation

StriderDM
Copy link
Contributor

Implements a daemon mode for the Tari Base Node

Description

Starts application without CLI parser when --daemon-mode argument is present.

Motivation and Context

How Has This Been Tested?

cargo-test --all --all-features

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I'm merging against the development branch.
  • I ran cargo-fmt --all before pushing.
  • I ran cargo test successfully before submitting my PR.
  • I have squashed my commits into a single commit.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

stringhandler added a commit to stringhandler/tari that referenced this pull request Oct 26, 2020
} else {
println!("Node has been successfully configured and initialized in daemon mode. Starting CLI loop.");
base_node_handle = rt.spawn(ctx.run());
cli_loop(None, shutdown);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just remove this call entirely?

Suggested change
cli_loop(None, shutdown);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@StriderDM StriderDM force-pushed the base_node_daemon_mode branch 2 times, most recently from 6227960 to 5ae77be Compare October 28, 2020 17:26
@delta1
Copy link
Contributor

delta1 commented Oct 29, 2020

Prob need a rebase, the clippy errors were fixed I think

@stringhandler stringhandler merged commit 35de5b5 into tari-project:development Nov 2, 2020
stringhandler added a commit that referenced this pull request Nov 24, 2020
Major changes since v0.6.0
---
- [#2431](#2431) Database refactor to remove checkpoints and more efficient calculation of MMR roots
- [#2352](#2352) Add DNS seed support in base node

Minor changes since v0.6.0
---
- [#2448](#2448) Add OpenSSL to Windows install, runtime
- [#2434](#2434) Add supervisord setup notes
- [#2439](#2439) Provide initial sync status to merge mining proxy
- [#2377](#2377) Message malleability detect and ban
- [#2447](#2447) Fix for xmrig powershell script
- [#2440](#2440) Stagenet Setup Guide Corrections
- [#2444](#2444) DHT connectivity waits for comms connectivity before starting
- [#2427](#2427) Update merge mining runtime, README, Win install
- [#2420](#2420) Show base node chain tip and sync status in the console wallet
- [#2419](#2419) Add optional fee_per_gram field to console wallet Send Tx form
- [#2421](#2421) Fix QR code rendering in the console wallet
- [#2423](#2423) Plumb in the balance in the console wallet
- [#2415](#2415) Prevent loop in peer sync by storing all peers attempted
- [#2383](#2383) Implement daemon-mode in tari_base_node
- [#2407](#2407) Simplify automated stress test
- [#2397](#2397) Fix preset config files
- [#2400](#2400) Implement wallet base node service
- [#2403](#2403) Add exclusive file locks to Wallet, Chain and Peer db’s
- [#2408](#2408) Fix wallet conversion error for a valid tx status
- [#2356](#2356) Combine validation code to use same function in pruned and archive mode.
- [#2371](#2371) Add configurable BN service request timeouts
- [#2430](#2430) Implement entry and persistence of custom base node in console wallet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants