Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Stibbons constants #2569

Merged
merged 1 commit into from
Jan 28, 2021
Merged

Fix Stibbons constants #2569

merged 1 commit into from
Jan 28, 2021

Conversation

SWvheerden
Copy link
Collaborator

Description

Fix the timestamp for stibbons reset
Fix the difficulties for stibbons

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I'm merging against the development branch.
  • I ran cargo-fmt --all before pushing.
  • I ran cargo test successfully before submitting my PR.
  • I have squashed my commits into a single commit.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@stringhandler stringhandler changed the title Fix stibbons constans Fix Stibbons constants Jan 28, 2021
delta1
delta1 approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@delta1 delta1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

delta1
delta1 suggested changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@delta1 delta1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy and compile error

@SWvheerden
Update timestamp for stibbons
f9ff2c2 
Fix difficulties for stibbons
@stringhandler stringhandler merged commit 15af6d2 into tari-project:stibbons Jan 28, 2021
@SWvheerden SWvheerden deleted the fix_stibbons_constants branch February 10, 2021 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delta1 delta1 delta1 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SWvheerden @delta1 @stringhandler