View QR code on console wallet on low res screens #2610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clippy/fmt |
done |
SWvheerden
force-pushed
the
sw_console_tui_resize
branch
from
1f2e11d
to
081043d
Compare
|
thanks will take a look |
stringhandler
approved these changes
Feb 4, 2021
stringhandler
added a commit
that referenced
this pull request
Feb 5, 2021
- [#2618](#2618) [console-wallet] Implement WalletNotify for console wallet TUI mode - [#2615](#2615) [base-node] Cucumber test for GRPC method relating to block explorer - [#2590](#2590) [console-wallet] Add filter to exclude not yet mature utxo's from transaction creation - [#2611](#2611) [chore] Fix tests - [#2609](#2609) [base-node] Restore get_network_difficulty GRPC method - [#2610](#2610) [console-wallet] View QR code on console wallet on low res screens - [#2604](#2604) [base-node] Move capping of target difficulty - [#2607](#2607) [chore] Fix tests - [#2601](#2601) [chore] Add seed node names to preset config - [#2600](#2600) [chore] Remove unmaintained bigint dep - [#2598](#2598) [tests] Fix tests breaking due to Fee vs Sent amount validation - [#2599](#2599) [tests] Add cucumber integration test txn status - [#2571](#2571) [chore] Remove test net temp code - [#2570](#2570) [chore] Wallet db migration cleanup - [#2596](#2596) [base-node] Update default pruning horizon to 1000 - [#2480](#2480) [docs] Update pool mining on mainnet readme - [#2597](#2597) [console-wallet] Add TXO validation to console wallet - [#2595](#2595) [MM_Proxy] Submit to origin daemon configuration - [#2593](#2593) Added Wallet Identify GRPC Methods, updated tests
|
Looks much better. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR splits the send and receive tab into two tabs.
Motivation and Context
On low res screens, see issue #2552 , we cant view the entire height of some screens. This makes sure that the visible info is visible on screens with a limited height.
How Has This Been Tested?
Types of changes
Checklist:
developmentbranch.cargo-fmt --allbefore pushing.cargo testsuccessfully before submitting my PR.