-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mining Node] Add mining node to distribution #2649
[Mining Node] Add mining node to distribution #2649
Conversation
Disable toggle_mining command in the base node. Add mining node to startup scripts. Update scripts to start mining node instead of using the enable_mining flag. Add mining node to distribution/installer for osx, linux, mac.
Looking good reviewing the changes; will run a full installer/tarball creation with installation test for Windows and Ubuntu. Notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
A little late to comment on this, but there are shell scripts that have been includes as binary files ... Now double checking and see them as empty files? |
@leet4tari They're not empty files. The two |
@hansieodendaal For your notes. Didn't know the first point was an issue on ubuntu. For the second point it should be, didn't change anything regarding the shortcuts, used what already existed for that. |
Looking in GitHub - https://github.com/StriderDM/tari/blob/21b50bc29e43c148284a52c9e55c8023aa9601d5/applications/tari_mining_node/osx/start_tari_mining_node.sh is empty/binary and not a symbolic link ... Alias is what I think Microsoft calls it? verse https://github.com/StriderDM/tari/blob/21b50bc29e43c148284a52c9e55c8023aa9601d5/applications/tari_base_node/osx/start_all I can't say anything about the Windows Alias to the |
@leet4tari Fixed here: Credit to @hansieodendaal |
Looked up git usage and symlinks ... Not sure why we using the symlinks, but might be an idea either to agree on and how they used. Reading https://stackoverflow.com/questions/954560/how-does-git-handle-symbolic-links seems like a can of worms we could avoid. |
@leet4tari I have seen that stackoverflow link. You can also have a look here https://mokacoding.com/blog/symliks-in-git/ They were created with the following:
|
Still looks broken in the web view on GitHub and both the articles show a folder with an arrow, that is what I expect from a symlink, but our repo shows a bin file, which we can't open using a browser via the web. I am just pointing this out, mostly to keep in mind. Could be how Windows deals with symlinks or maybe a change to git.core settings. This is just a warning. |
Changes since v0.8.2 Base Node --- - [#2635](#2635) [base-node] Add user agent to peer display info (#2635) - [#2626](#2626) [base-node] Add duplicate input_output tx validator Wallet --- - [#2656](#2656) [wallet] Fixed timelocked balance - [#2632](#2632) [wallet] Update TXO validation protocol to use RPC interface to base node - [#2624](#2624) [wallet] Set confirmations required via libwallet and config - [#2644](#2644) [wallet] Add unique constraint to commitment in outputs table - [#2637](#2637) [wallet] Update Transaction Receiver protocol to persist transaction earlier - [#2625](#2625) [wallet] Remove the Tor identity getter from the FFI - [#2614](#2614) [wallet] New Transaction Validation protocol for Wallet - [#2619](#2619) [wallet] Add tx sending mechanism to wallet Mining Node --- - [#2652](#2652) [mining-node] Recreated symlinks without extension - [#2649](#2649) [mining-node] Add mining node to distribution Merge Mining Proxy --- - [#2631](#2631) [mmproxy] Fix missing Content-Type header in some json responses - [#2616](#2616) [merge-mining] submit_block returns OK if block was submitted for tari or monero Other --- - [#2655](#2655) [tests] Remove cancelled output excluded test - [#2647](#2647) [tests] Minor improvements to DHT logging - [#2653](#2653) [tests] Speed up `Transaction Info` Cucumber test - [#2643](#2643) [common] Dont propagate messages we have already - [#2612](#2612) [ci] Optimize integration tests - [#2651](#2651) [tests] Fix num confirmations test backend - [#2641](#2641) [common] Retry peers that have been marked as offline after a length of time - [#2650](#2650) [ci] Allow CI to use latest mdbook - [#2627](#2627) [tests] Double spend test for mempool transaction selection - [#2623](#2623) [chore] Add extra logging to help investigate fee mismatch - [#2630](#2630) [common] Shorter ban for RPC negotiation timeout in header sync, RPC timeout configurable - [#2629](#2629) [chore] Clean up duplicate check - [#2628](#2628) [tests] Add test_find_duplicate_input - [#2648](#2648) [ci] Run cargo test with verbose output - [#2638](#2638) [common] Ban peers that flood messages - [#2636](#2636) [explorer] Add a nodejs block explorer - [#2634](#2634) [fix] Dont store messages of a banned peer - [#2613](#2613) [tests] Add unit tests for lock heights
Changes since v0.8.2 Base Node --- - [#2635](#2635) [base-node] Add user agent to peer display info (#2635) - [#2626](#2626) [base-node] Add duplicate input_output tx validator Wallet --- - [#2656](#2656) [wallet] Fixed timelocked balance - [#2632](#2632) [wallet] Update TXO validation protocol to use RPC interface to base node - [#2624](#2624) [wallet] Set confirmations required via libwallet and config - [#2644](#2644) [wallet] Add unique constraint to commitment in outputs table - [#2637](#2637) [wallet] Update Transaction Receiver protocol to persist transaction earlier - [#2625](#2625) [wallet] Remove the Tor identity getter from the FFI - [#2614](#2614) [wallet] New Transaction Validation protocol for Wallet - [#2619](#2619) [wallet] Add tx sending mechanism to wallet Mining Node --- - [#2652](#2652) [mining-node] Recreated symlinks without extension - [#2649](#2649) [mining-node] Add mining node to distribution Merge Mining Proxy --- - [#2631](#2631) [mmproxy] Fix missing Content-Type header in some json responses - [#2616](#2616) [merge-mining] submit_block returns OK if block was submitted for tari or monero Other --- - [#2655](#2655) [tests] Remove cancelled output excluded test - [#2647](#2647) [tests] Minor improvements to DHT logging - [#2653](#2653) [tests] Speed up `Transaction Info` Cucumber test - [#2643](#2643) [common] Dont propagate messages we have already - [#2612](#2612) [ci] Optimize integration tests - [#2651](#2651) [tests] Fix num confirmations test backend - [#2641](#2641) [common] Retry peers that have been marked as offline after a length of time - [#2650](#2650) [ci] Allow CI to use latest mdbook - [#2627](#2627) [tests] Double spend test for mempool transaction selection - [#2623](#2623) [chore] Add extra logging to help investigate fee mismatch - [#2630](#2630) [common] Shorter ban for RPC negotiation timeout in header sync, RPC timeout configurable - [#2629](#2629) [chore] Clean up duplicate check - [#2628](#2628) [tests] Add test_find_duplicate_input - [#2648](#2648) [ci] Run cargo test with verbose output - [#2638](#2638) [common] Ban peers that flood messages - [#2636](#2636) [explorer] Add a nodejs block explorer - [#2634](#2634) [fix] Dont store messages of a banned peer - [#2613](#2613) [tests] Add unit tests for lock heights
Changes since v0.8.2 Base Node --- - [#2635](#2635) [base-node] Add user agent to peer display info (#2635) - [#2626](#2626) [base-node] Add duplicate input_output tx validator Wallet --- - [#2656](#2656) [wallet] Fixed timelocked balance - [#2632](#2632) [wallet] Update TXO validation protocol to use RPC interface to base node - [#2624](#2624) [wallet] Set confirmations required via libwallet and config - [#2644](#2644) [wallet] Add unique constraint to commitment in outputs table - [#2637](#2637) [wallet] Update Transaction Receiver protocol to persist transaction earlier - [#2625](#2625) [wallet] Remove the Tor identity getter from the FFI - [#2614](#2614) [wallet] New Transaction Validation protocol for Wallet - [#2619](#2619) [wallet] Add tx sending mechanism to wallet Mining Node --- - [#2652](#2652) [mining-node] Recreated symlinks without extension - [#2649](#2649) [mining-node] Add mining node to distribution Merge Mining Proxy --- - [#2631](#2631) [mmproxy] Fix missing Content-Type header in some json responses - [#2616](#2616) [merge-mining] submit_block returns OK if block was submitted for tari or monero Other --- - [#2655](#2655) [tests] Remove cancelled output excluded test - [#2647](#2647) [tests] Minor improvements to DHT logging - [#2653](#2653) [tests] Speed up `Transaction Info` Cucumber test - [#2643](#2643) [common] Dont propagate messages we have already - [#2612](#2612) [ci] Optimize integration tests - [#2651](#2651) [tests] Fix num confirmations test backend - [#2641](#2641) [common] Retry peers that have been marked as offline after a length of time - [#2650](#2650) [ci] Allow CI to use latest mdbook - [#2627](#2627) [tests] Double spend test for mempool transaction selection - [#2623](#2623) [chore] Add extra logging to help investigate fee mismatch - [#2630](#2630) [common] Shorter ban for RPC negotiation timeout in header sync, RPC timeout configurable - [#2629](#2629) [chore] Clean up duplicate check - [#2628](#2628) [tests] Add test_find_duplicate_input - [#2648](#2648) [ci] Run cargo test with verbose output - [#2638](#2638) [common] Ban peers that flood messages - [#2636](#2636) [explorer] Add a nodejs block explorer - [#2634](#2634) [fix] Dont store messages of a banned peer - [#2613](#2613) [tests] Add unit tests for lock heights
Description
Disable toggle_mining command in the base node.
Add mining node to startup scripts.
Update scripts to start mining node instead of using the enable_mining flag.
Add mining node to distribution/installer for osx, linux, mac.
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
development
branch.cargo-fmt --all
before pushing.cargo test
successfully before submitting my PR.