Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make-it-rain bug #2730

Merged

Conversation

hansieodendaal
Copy link
Contributor

Description

Fixed make-it-rain bug

Motivation and Context

The delay calculation was done using u64; it should be done with i64 to prevent wrap around.

How Has This Been Tested?

As per the original base node wallet implementation

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I'm merging against the development branch.
  • I ran cargo-fmt --all before pushing.
  • I ran cargo test successfully before submitting my PR.
  • I have squashed my commits into a single commit.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

The delay calculation was done using `u64`; it should be
done with `i64` to prevent wrap around.
@stringhandler stringhandler merged commit 3bb81a8 into tari-project:development Mar 8, 2021
@stringhandler stringhandler mentioned this pull request Mar 10, 2021
@hansieodendaal hansieodendaal deleted the ho_make_it_rain_bug branch March 30, 2021 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants