[comms] Connection manager requester not exposed on CommsNode #2815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes deprecated `CommsNode::connection_manager` method that exposes an interface internal to comms. The connectivity interface should be used instead.
stringhandler
approved these changes
Mar 31, 2021
stringhandler
added a commit
that referenced
this pull request
Apr 1, 2021
Changes since v0.8.6 Wallet --- - [#2825](#2825) [wallet] correctly log RPC error messages - [#2824](#2824) [wallet] Output error message for ConfigError - [#2818](#2818) [wallet] get_transaction_info no longer errors if any transaction is not found - [#2819](#2819) [wallet] Clear UI before starting UI loop - [#2798](#2798) [wallet] Add MinedUnconfirmed to command mode wait stage - [#2793](#2793) [wallet] Add menu to console wallet - [#2765](#2765) [wallet] Friendly incorrect password message - [#2753](#2753) [wallet] Update base node service to use RPC - [#2762](#2762) [wallet] Implement wallet recovery process in LibWallet FFI - [#2761](#2761) [wallet] Differentiate "funds pending" case in UTXO selection - [#2748](#2748) [wallet] Added saf message duration to configuration Base Node --- - [#2814](#2814) [base-node] Add previous hash check to sync validator - [#2759](#2759) [base-node] Fix handling of large chain reorgs in header sync - [#2813](#2813) [base-node] Add rewind-blockchain and improve header-stats command - [#2795](#2795) [base-node] Update mempool consensus validator to check weight excluding coinbase - [#2738](#2738) [base-node] Rewind prune mode behind horizon - [#2768](#2768) [base-node] Add transaction consensus validator - [#2764](#2764) [base-node] Remove reorgs from total tx count - [#2755](#2755) [base-node] Node bootstraps after initial sync if all other nodes are h=0 - [#2751](#2751) [base-node] Minor fix for list-headers Mining --- - [#2807](#2807) [merge-mining] Added getLastBlockHeader cucumber test - [#2792](#2792) [mining-node] Added additional command line arguments - [#2791](#2791) [merge-mining] Add stdout information - [#2767](#2767) [mmproxy] Expanded cucumber tests for merged mining proxy - [#2743](#2743) [merge-mining] Fix logic flaw in proxy_request_to_monerod Other --- - [#2826](#2826) [common] Add rpc_max_simultaneous_sessions setting to config - [#2823](#2823) [chore] Fix import - [#2822](#2822) [chore] Update prettier paths - [#2815](#2815) [comms] Connection manager requester not exposed on CommsNode - [#2820](#2820) [chore] Use prettier for integration tests - [#2821](#2821) [other] Add memory net summary - [#2757](#2757) [ci] Add all-targets to clippy - [#2796](#2796) [docs] Add WalletNotify info to config samples - [#2773](#2773) [tests] Add custom log file paths for wallet and mmproxy - [#2763](#2763) [tests] Update mempool waits to be dynamic - [#2769](#2769) [ci] Increase Cucumber CI to include all tests except "long running" - [#2747](#2747) [docs] Update rfc 201 for coinbase - [#276](#276) [chore] Removed some unused dependencies - [#2576](#2576) [common] Increase flood ban config - [#2572](#2572) [tests] Add cucumber test verify meddling with MMR sizes - [#2754](#2754) [common] Emit rerun-if-changed directives for include protos - [#2745](#2745) [ci] Point Circle CI status badge to development branch only - [#2744](#2744) [docs] Minor Fixes - [#2740](#2740) [chore] Remove the text_message_service from the wallet (#2740) - [#2739](#2739) [docs] Document the NO_OP TariScript vulnerability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes deprecated
CommsNode::connection_managermethod that exposesan interface internal to comms. The connectivity interface should be used instead.
Motivation and Context
Connection manager is an internal comms interface and should never be interfaced with externally. Doing this could lead to bugs so the interface was removed.
How Has This Been Tested?
Existing tests pass
Types of changes
Checklist:
developmentbranch.cargo-fmt --allbefore pushing.cargo testsuccessfully before submitting my PR.