Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix console wallet calls in runtime scripts for stibbons #2572

Merged
merged 1 commit into from Jan 29, 2021
Merged

Fix console wallet calls in runtime scripts for stibbons #2572

merged 1 commit into from Jan 29, 2021

Conversation

hansieodendaal
Copy link
Contributor

@hansieodendaal hansieodendaal commented Jan 28, 2021 •
edited

Description

Due to changes in how the wallet starts up, it does not have to run twice anymore if init needs to be done. This PR changes the startup scripts accordingly. See related changes in #2571.

Motivation and Context

See above,

How Has This Been Tested?

Tested in tari_console_wallet startup in Windows and Ubuntu

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I'm merging against the development branch.
  • I ran cargo-fmt --all before pushing.
  • I ran cargo test successfully before submitting my PR.
  • I have squashed my commits into a single commit.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@hansieodendaal hansieodendaal changed the title Fix console wallet runtime calls Fix console wallet calls in runtime scripts Jan 28, 2021
@hansieodendaal hansieodendaal changed the title Fix console wallet calls in runtime scripts Fix console wallet calls in runtime scripts for stibbons Jan 28, 2021
@hansieodendaal
Fix console wallet runtime calls
0cfc900 
Due to changes in how the wallet starts up, it does not
have to run twice anymore if `init` needs to be done. This
PR changes the startup scripts accordingly.
@stringhandler stringhandler merged commit f7f6398 into tari-project:development Jan 29, 2021
stringhandler added a commit that referenced this pull request Jan 29, 2021
@stringhandler
v0.8.1
7697db8 
Changes since v0.8.0

- [#2587](#2587) Correct block times
- [#2572](#2572) Fix console wallet runtime calls
- [#2559](#2559) Add Cucumber to CI
- [#2574](#2574) Update libwallet build for Github actions
- [#2583](#2583) Remove "add one to port" hack in console wallet
- [#2585](#2585) Move generated proto files to OUT_DIR
- [#2584](#2584) Update fee vs amount being sent validation
- [#2578](#2578) Fix submit block in integration test
- [#2576](#2576) Remove Ridcully references from Stibbons code
- [#2582](#2582) Remove generated proto files from tari_core
- [#2577](#2577) Fix for auotmated wallet startup
@stringhandler stringhandler mentioned this pull request Jan 29, 2021
Merged
@hansieodendaal hansieodendaal deleted the ho_stibbons_wallet_startup branch February 3, 2021 11:17
stringhandler added a commit that referenced this pull request Mar 16, 2021
@stringhandler
Merge #2572: [tests] Add cucumber test verify meddling with MMR sizes
95499a7 
Add cucumber test verify meddling with MMR sizes
 the commit.
stringhandler added a commit that referenced this pull request Apr 1, 2021
@stringhandler
v0.8.7
8076922 
Changes since v0.8.6

Wallet
---
- [#2825](#2825) [wallet] correctly log RPC error messages
- [#2824](#2824) [wallet] Output error message for ConfigError
- [#2818](#2818) [wallet] get_transaction_info no longer errors if any transaction is not found
- [#2819](#2819) [wallet] Clear UI before starting UI loop
- [#2798](#2798) [wallet] Add MinedUnconfirmed to command mode wait stage
- [#2793](#2793) [wallet] Add menu to console wallet
- [#2765](#2765) [wallet] Friendly incorrect password message
- [#2753](#2753) [wallet] Update base node service to use RPC
- [#2762](#2762) [wallet] Implement wallet recovery process in LibWallet FFI
- [#2761](#2761) [wallet] Differentiate "funds pending" case in UTXO selection
- [#2748](#2748) [wallet] Added saf message duration to configuration

Base Node
---
- [#2814](#2814) [base-node] Add previous hash check to sync validator
- [#2759](#2759) [base-node] Fix handling of large chain reorgs in header sync
- [#2813](#2813) [base-node] Add rewind-blockchain and improve header-stats command
- [#2795](#2795) [base-node] Update mempool consensus validator to check weight excluding coinbase
- [#2738](#2738) [base-node] Rewind prune mode behind horizon
- [#2768](#2768) [base-node] Add transaction consensus validator
- [#2764](#2764) [base-node] Remove reorgs from total tx count
- [#2755](#2755) [base-node] Node bootstraps after initial sync if all other nodes are h=0
- [#2751](#2751) [base-node] Minor fix for list-headers

Mining
---
- [#2807](#2807) [merge-mining] Added getLastBlockHeader cucumber test
- [#2792](#2792) [mining-node] Added additional command line arguments
- [#2791](#2791) [merge-mining] Add stdout information
- [#2767](#2767) [mmproxy] Expanded cucumber tests for merged mining proxy
- [#2743](#2743) [merge-mining] Fix logic flaw in proxy_request_to_monerod

Other
---
- [#2826](#2826) [common] Add rpc_max_simultaneous_sessions setting to config
- [#2823](#2823) [chore] Fix import
- [#2822](#2822) [chore] Update prettier paths
- [#2815](#2815) [comms] Connection manager requester not exposed on CommsNode
- [#2820](#2820) [chore] Use prettier for integration tests
- [#2821](#2821) [other] Add memory net summary
- [#2757](#2757) [ci] Add all-targets to clippy
- [#2796](#2796) [docs] Add WalletNotify info to config samples
- [#2773](#2773) [tests] Add custom log file paths for wallet and mmproxy
- [#2763](#2763) [tests] Update mempool waits to be dynamic
- [#2769](#2769) [ci] Increase Cucumber CI to include all tests except "long running"
- [#2747](#2747) [docs] Update rfc 201 for coinbase
- [#276](#276) [chore] Removed some unused dependencies
- [#2576](#2576) [common] Increase flood ban config
- [#2572](#2572) [tests] Add cucumber test verify meddling with MMR sizes
- [#2754](#2754) [common] Emit rerun-if-changed directives for include protos
- [#2745](#2745) [ci] Point Circle CI status badge to development branch only
- [#2744](#2744) [docs] Minor Fixes
- [#2740](#2740) [chore] Remove the text_message_service from the wallet (#2740)
- [#2739](#2739) [docs] Document the NO_OP TariScript vulnerability
@stringhandler stringhandler mentioned this pull request Apr 1, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stringhandler stringhandler stringhandler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hansieodendaal @stringhandler