-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test to reproduce target difficulty problem #2868
Merged
stringhandler
merged 1 commit into
tari-project:development
from
stringhandler:mb-target-difficulty-test
Apr 26, 2021
Merged
Test to reproduce target difficulty problem #2868
stringhandler
merged 1 commit into
tari-project:development
from
stringhandler:mb-target-difficulty-test
Apr 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
force-pushed
the
mb-target-difficulty-test
branch
from
April 22, 2021 15:54
5aa5284
to
470b882
Compare
stringhandler
changed the title
WIP Test to reproduce target difficulty problem
Test to reproduce target difficulty problem
Apr 22, 2021
stringhandler
force-pushed
the
mb-target-difficulty-test
branch
from
April 23, 2021 11:20
470b882
to
0c4e37e
Compare
LGTM just needs clippy |
and merge conflicts |
SWvheerden
previously approved these changes
Apr 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
stringhandler
force-pushed
the
mb-target-difficulty-test
branch
from
April 23, 2021 13:12
0c4e37e
to
a1228e9
Compare
stringhandler
force-pushed
the
mb-target-difficulty-test
branch
from
April 23, 2021 13:27
a1228e9
to
0242ea1
Compare
delta1
approved these changes
Apr 23, 2021
sdbondi
approved these changes
Apr 25, 2021
stringhandler
added a commit
that referenced
this pull request
Apr 28, 2021
Changes since v0.8.8: Base Node --- - [#2870](#2870) [base-node] Fixes and tidies up prune mode cleanup - [#2857](#2857) [base-node] Optimise pruned UTXO sync streaming protocol - [#2868](#2868) [base-node] Test to reproduce target difficulty problem Wallet --- - [#2867](#2867) [wallet] Add option to write unblinded UTXOs to CSV file - [#2862](#2862) [wallet] Add mined height to display of mined transactions in Console Wallet Common --- - [#2876](#2876) [common] Fix incorrect boolean condition - [#2873](#2873) [tests] Fix case of cucumber - [#2837](#2837) [docs] Clarify one sided payment - [#2871](#2871) [tests] Update tests to use sha3 - [#2855](#2855) [tests] Fix re-org test
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test to cover handle_possible_reorg
Motivation and Context
This is an attempt to reproduce the error when a target difficulty is overwritten by the wrong block. At the moment the test passes, so doesn't actually reproduce it
How Has This Been Tested?
It is a test
Checklist:
development
branch.