Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test to reproduce target difficulty problem #2868

Conversation

stringhandler
Copy link
Collaborator

@stringhandler stringhandler commented Apr 22, 2021

Description

Test to cover handle_possible_reorg

Motivation and Context

This is an attempt to reproduce the error when a target difficulty is overwritten by the wrong block. At the moment the test passes, so doesn't actually reproduce it

How Has This Been Tested?

It is a test

Checklist:

  • I'm merging against the development branch.
  • I have squashed my commits into a single commit.

@stringhandler stringhandler marked this pull request as draft April 22, 2021 06:53
@stringhandler stringhandler changed the title WIP Test to reproduce target difficulty problem Test to reproduce target difficulty problem Apr 22, 2021
@stringhandler stringhandler marked this pull request as ready for review April 22, 2021 16:08
@delta1
Copy link
Contributor

delta1 commented Apr 23, 2021

LGTM just needs clippy

@delta1
Copy link
Contributor

delta1 commented Apr 23, 2021

and merge conflicts

SWvheerden
SWvheerden previously approved these changes Apr 23, 2021
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stringhandler stringhandler merged commit 714ffeb into tari-project:development Apr 26, 2021
@stringhandler stringhandler deleted the mb-target-difficulty-test branch April 26, 2021 06:14
stringhandler added a commit that referenced this pull request Apr 28, 2021
Changes since v0.8.8:

Base Node
---
- [#2870](#2870) [base-node] Fixes and tidies up prune mode cleanup
- [#2857](#2857) [base-node] Optimise pruned UTXO sync streaming protocol
- [#2868](#2868) [base-node] Test to reproduce target difficulty problem

Wallet
---
- [#2867](#2867) [wallet] Add option to write unblinded UTXOs to CSV file
- [#2862](#2862) [wallet] Add mined height to display of mined transactions in Console Wallet

Common
---
- [#2876](#2876) [common] Fix incorrect boolean condition
- [#2873](#2873) [tests] Fix case of cucumber
- [#2837](#2837) [docs] Clarify one sided payment
- [#2871](#2871) [tests] Update tests to use sha3
- [#2855](#2855) [tests] Fix re-org test
@stringhandler stringhandler mentioned this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants