fix: update cucumber tests for walletffi.feature #3275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StriderDM
force-pushed
the
cucumber_saf_test
branch
3 times, most recently
from
656cbb9
to
8314755
Compare
StriderDM
force-pushed
the
cucumber_saf_test
branch
from
8314755
to
7b549a9
Compare
StriderDM
force-pushed
the
cucumber_saf_test
branch
6 times, most recently
from
992de39
to
1e23c00
Compare
Made types more explicit for ffi interface and easier to maintain going forwards. Initialized InterfaceFFI in world rather than WalletFFIClient. Updated steps in WalletFFI.feature Updated some const variables in wrapper classes to be let. Better handling of callback function pointer variables in wallet. Added additional steps to tests. Update WalletFFI.feature Update wallet.js Fixed leak in wallet Fixed leak for transport in walletFFI client. Renamed pointer variable for each struct in wrapper to ptr Review comments Added waitForIterate to util. Refer to CString instead of string in interface types. Replace uint64 type with ulonglong type Downgrade code to be compatible with NodeJS v12 Update config.yml
StriderDM
force-pushed
the
cucumber_saf_test
branch
from
1e23c00
to
4cb1894
Compare
stringhandler
approved these changes
Sep 2, 2021
aviator-app bot
pushed a commit
that referenced
this pull request
Sep 3, 2021
Description Exposed TariTransactionKernel instead of TariExcess, TariExcessSignature and TariExcessPublicNonce. This was done as they are all referring to fields from the same object and also to reduce the amount of wrapper classes needs on the other side of the FFI boundary. Added accessor methods to retrieve data from the opaque pointer for TariTransactionKernel and return the data as a type (in this instance a cstring) which can safely cross the FFI boundary. Updated library header. Updated rust tests. Updated cucumber tests. Updated comments. Incremented library version. Merge #3275 first. Motivation and Context --- How Has This Been Tested? cargo test --all --all-features nvm use v12.22.6 && ./node_modules/.bin/cucumber-js features/WalletFFI.feature 
Cifko
pushed a commit
to Cifko/tari
that referenced
this pull request
Sep 10, 2021
Description Exposed TariTransactionKernel instead of TariExcess, TariExcessSignature and TariExcessPublicNonce. This was done as they are all referring to fields from the same object and also to reduce the amount of wrapper classes needs on the other side of the FFI boundary. Added accessor methods to retrieve data from the opaque pointer for TariTransactionKernel and return the data as a type (in this instance a cstring) which can safely cross the FFI boundary. Updated library header. Updated rust tests. Updated cucumber tests. Updated comments. Incremented library version. Merge tari-project#3275 first. Motivation and Context --- How Has This Been Tested? cargo test --all --all-features nvm use v12.22.6 && ./node_modules/.bin/cucumber-js features/WalletFFI.feature 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made types more explicit for ffi interface and easier to maintain going forwards.
Initialized InterfaceFFI in world rather than WalletFFIClient.
Updated steps in WalletFFI.feature
Updated some const variables in wrapper classes to be let.
Better handling of callback function pointer variables in wallet.
Added additional steps to tests.
Downgrade code to be compatible with nodejs v12.
Motivation and Context
How Has This Been Tested?
nvm use v12.22.6 && ./node_modules/.bin/cucumber-js features/WalletFFI.feature
Run log:
run.log
NodeJS version downgrade:
tari-labs/docker#16