Downgrade nodeJS to v12 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviator-app bot
pushed a commit
to tari-project/tari
that referenced
this pull request
Sep 2, 2021
Description Made types more explicit for ffi interface and easier to maintain going forwards. Initialized InterfaceFFI in world rather than WalletFFIClient. Updated steps in WalletFFI.feature Updated some const variables in wrapper classes to be let. Better handling of callback function pointer variables in wallet. Added additional steps to tests. Downgrade code to be compatible with nodejs v12. Motivation and Context How Has This Been Tested? nvm use v12.22.6 && ./node_modules/.bin/cucumber-js features/WalletFFI.feature Run log: [run.log](https://github.com/tari-project/tari/files/7097096/run.log) NodeJS version downgrade: tari-labs/docker#16
stringhandler
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.